public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define?
@ 2021-02-07 23:08 Sedat Dilek
  2021-02-07 23:25 ` Kyle Huey
  2021-02-07 23:27 ` Bhaskar Chowdhury
  0 siblings, 2 replies; 5+ messages in thread
From: Sedat Dilek @ 2021-02-07 23:08 UTC (permalink / raw)
  To: Linus Torvalds, Gabriel Krisman Bertazi, Thomas Gleixner
  Cc: Kyle Huey, linux-kernel

Hi,

congrats to Linux v5.11-rc7.

after commit 6342adcaa683 ("entry: Ensure trap after single-step on
system call return"):

$ git grep '\_TIF_SINGLESTEP' arch/x86/
arch/x86/include/asm/thread_info.h:#define _TIF_SINGLESTEP
 (1 << TIF_SINGLESTEP)

Is this a leftover and can be removed (now)?

Thanks.

Regards,
- Sedat -

[1] https://marc.info/?l=linux-kernel&m=161273724611262&w=2
[2] https://git.kernel.org/linus/6342adcaa683

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define?
  2021-02-07 23:08 [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define? Sedat Dilek
@ 2021-02-07 23:25 ` Kyle Huey
  2021-02-08  2:18   ` Sedat Dilek
  2021-02-07 23:27 ` Bhaskar Chowdhury
  1 sibling, 1 reply; 5+ messages in thread
From: Kyle Huey @ 2021-02-07 23:25 UTC (permalink / raw)
  To: sedat.dilek
  Cc: Linus Torvalds, Gabriel Krisman Bertazi, Thomas Gleixner,
	open list

On Sun, Feb 7, 2021 at 3:09 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> Hi,
>
> congrats to Linux v5.11-rc7.
>
> after commit 6342adcaa683 ("entry: Ensure trap after single-step on
> system call return"):
>
> $ git grep '\_TIF_SINGLESTEP' arch/x86/
> arch/x86/include/asm/thread_info.h:#define _TIF_SINGLESTEP
>  (1 << TIF_SINGLESTEP)
>
> Is this a leftover and can be removed (now)?
>
> Thanks.
>
> Regards,
> - Sedat -
>
> [1] https://marc.info/?l=linux-kernel&m=161273724611262&w=2
> [2] https://git.kernel.org/linus/6342adcaa683

Yes it looks like that can be removed now.

- Kyle

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define?
  2021-02-07 23:08 [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define? Sedat Dilek
  2021-02-07 23:25 ` Kyle Huey
@ 2021-02-07 23:27 ` Bhaskar Chowdhury
  2021-02-08  2:18   ` Sedat Dilek
  1 sibling, 1 reply; 5+ messages in thread
From: Bhaskar Chowdhury @ 2021-02-07 23:27 UTC (permalink / raw)
  To: Sedat Dilek
  Cc: Linus Torvalds, Gabriel Krisman Bertazi, Thomas Gleixner,
	Kyle Huey, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On 00:08 Mon 08 Feb 2021, Sedat Dilek wrote:
>Hi,
>
>congrats to Linux v5.11-rc7.
>
>after commit 6342adcaa683 ("entry: Ensure trap after single-step on
>system call return"):
>
>$ git grep '\_TIF_SINGLESTEP' arch/x86/
>arch/x86/include/asm/thread_info.h:#define _TIF_SINGLESTEP
> (1 << TIF_SINGLESTEP)
>
Does it failed the build???

Just curious??

>Is this a leftover and can be removed (now)?
>
>Thanks.
>
>Regards,
>- Sedat -
>
>[1] https://marc.info/?l=linux-kernel&m=161273724611262&w=2
>[2] https://git.kernel.org/linus/6342adcaa683

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define?
  2021-02-07 23:25 ` Kyle Huey
@ 2021-02-08  2:18   ` Sedat Dilek
  0 siblings, 0 replies; 5+ messages in thread
From: Sedat Dilek @ 2021-02-08  2:18 UTC (permalink / raw)
  To: Kyle Huey
  Cc: Linus Torvalds, Gabriel Krisman Bertazi, Thomas Gleixner,
	open list

On Mon, Feb 8, 2021 at 12:25 AM Kyle Huey <me@kylehuey.com> wrote:
>
> On Sun, Feb 7, 2021 at 3:09 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >
> > Hi,
> >
> > congrats to Linux v5.11-rc7.
> >
> > after commit 6342adcaa683 ("entry: Ensure trap after single-step on
> > system call return"):
> >
> > $ git grep '\_TIF_SINGLESTEP' arch/x86/
> > arch/x86/include/asm/thread_info.h:#define _TIF_SINGLESTEP
> >  (1 << TIF_SINGLESTEP)
> >
> > Is this a leftover and can be removed (now)?
> >
> > Thanks.
> >
> > Regards,
> > - Sedat -
> >
> > [1] https://marc.info/?l=linux-kernel&m=161273724611262&w=2
> > [2] https://git.kernel.org/linus/6342adcaa683
>
> Yes it looks like that can be removed now.
>

Hi Kylem

Thanks for the confirmation.

Shall I send a patch?
With an ACK of you or mention in the commit message?

- Sedat -

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define?
  2021-02-07 23:27 ` Bhaskar Chowdhury
@ 2021-02-08  2:18   ` Sedat Dilek
  0 siblings, 0 replies; 5+ messages in thread
From: Sedat Dilek @ 2021-02-08  2:18 UTC (permalink / raw)
  To: Bhaskar Chowdhury, Sedat Dilek, Linus Torvalds,
	Gabriel Krisman Bertazi, Thomas Gleixner, Kyle Huey, linux-kernel

On Mon, Feb 8, 2021 at 12:27 AM Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote:
>
> On 00:08 Mon 08 Feb 2021, Sedat Dilek wrote:
> >Hi,
> >
> >congrats to Linux v5.11-rc7.
> >
> >after commit 6342adcaa683 ("entry: Ensure trap after single-step on
> >system call return"):
> >
> >$ git grep '\_TIF_SINGLESTEP' arch/x86/
> >arch/x86/include/asm/thread_info.h:#define _TIF_SINGLESTEP
> > (1 << TIF_SINGLESTEP)
> >
> Does it failed the build???
>
> Just curious??
>

No, it is simply a leftover.
Kyle confirmed.

I was able to build and boot into bare metal.


- Sedat -

> >Is this a leftover and can be removed (now)?
> >
> >Thanks.
> >
> >Regards,
> >- Sedat -
> >
> >[1] https://marc.info/?l=linux-kernel&m=161273724611262&w=2
> >[2] https://git.kernel.org/linus/6342adcaa683

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-02-08  2:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-07 23:08 [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define? Sedat Dilek
2021-02-07 23:25 ` Kyle Huey
2021-02-08  2:18   ` Sedat Dilek
2021-02-07 23:27 ` Bhaskar Chowdhury
2021-02-08  2:18   ` Sedat Dilek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox