From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F6FC433E0 for ; Mon, 8 Feb 2021 21:07:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F7DC64E50 for ; Mon, 8 Feb 2021 21:07:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235223AbhBHVGj (ORCPT ); Mon, 8 Feb 2021 16:06:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:47330 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235235AbhBHT7V (ORCPT ); Mon, 8 Feb 2021 14:59:21 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E843C64E66; Mon, 8 Feb 2021 19:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612814320; bh=xsVnUONVU12AQRO6QNzMNapi548nvENqlk3IOoifORg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ITMxK80yGma4CLdDdizhZPcd+9wHtJWS3fzTtVvrxoo5oyOx+YgPwGPZRKAsgzjDu uoC6QWKV6xlE55648MN1pky2gpFn9glNgm7h0JlNLgPj5Db+UD/K7Xj6Z24D+mTawB /GxfLPnGNTkx9dzR+ypQcJNzB4fD+kwsxZ7ItIcw= Date: Mon, 8 Feb 2021 20:58:37 +0100 From: Greg KH To: Mukul Mehar Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]: checkpatch: Fixed styling issue Message-ID: References: <20210208195116.GA19781@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210208195116.GA19781@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 01:21:16AM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. > > This patch fixes a warning, of the line ending with a '(', > generated by checkpatch.pl. > This is my first patch. > > Signed-off-by: Mukul Mehar > --- > drivers/staging/most/sound/sound.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c > index 3a1a59058042..4dd1bf95d1ce 100644 > --- a/drivers/staging/most/sound/sound.c > +++ b/drivers/staging/most/sound/sound.c > @@ -228,12 +228,12 @@ static int playback_thread(void *data) > struct mbo *mbo = NULL; > bool period_elapsed = false; > > - wait_event_interruptible( > - channel->playback_waitq, > - kthread_should_stop() || > - (channel->is_stream_running && > - (mbo = most_get_mbo(channel->iface, channel->id, > - &comp)))); > + wait_event_interruptible(channel->playback_waitq, > + kthread_should_stop() || > + (channel->is_stream_running && > + (mbo = most_get_mbo(channel->iface, > + channel->id, > + &comp)))); > if (!mbo) > continue; > > -- > 2.25.1 Again, all of the things that my bot found last time are still relevant here. Please fix them all. thanks, greg k-h