From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0E0EC433DB for ; Tue, 9 Feb 2021 11:19:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B01464E74 for ; Tue, 9 Feb 2021 11:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230262AbhBILSs (ORCPT ); Tue, 9 Feb 2021 06:18:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:46162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbhBILNn (ORCPT ); Tue, 9 Feb 2021 06:13:43 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F31FE64E4B; Tue, 9 Feb 2021 11:13:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612869182; bh=6x2uQVtjwUOwoznLE5QMUWQ0+QbCr0WByIxKCkNJemw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y2oErq6zh3CsnyRPdTyRqnl5jO/CVp/bxlFkujnMqxr51nJELeV7hMwVQeXzmNKQY M+9hUzAIgoMp8B9muIV0eR0OWEq6VToDcxU3QS52/UavosJ/5IVQTV4BIEVNz3RNeK VlDQ45tR+57FaQBdldpyaOIgLquimT5XgYF9Gkgc= Date: Tue, 9 Feb 2021 12:13:00 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Ard Biesheuvel , "Gustavo A . R . Silva" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: google: make coreboot driver's remove callback return void Message-ID: References: <20210126215339.706021-1-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210126215339.706021-1-uwe@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 10:53:39PM +0100, Uwe Kleine-König wrote: > All coreboot drivers return 0 unconditionally in their remove callback. > Also the device core ignores the return value of the struct > bus_type::remove(), so make the coreboot remove callback return void > instead of giving driver authors the illusion they could return an error > code here. > > All drivers are adapted accordingly. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > there is no registerd maintainer of this code. I assume so Greg will > pick this up?! Now picked up, thanks. greg k-h