Re: [PATCH] staging: rtl8723bs: fix block comments alignment

karthek
2021-02-09T21:51:27Z

On Wed, Feb 10, 2021 at 12:39:15AM +0530, karthek wrote:
> On Tue, Feb 09, 2021 at 07:59:02PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Feb 10, 2021 at 12:23:17AM +0530, karthik alapati wrote:
> > > fix checkpatch.pl warning for "block comments should align the * on each line"
> > >
> > > Signed-off-by: karthik alapati <mail@karthek.com>
> > > ---
> > > .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 204 +++++++++---------
> > > 1 file changed, 102 insertions(+), 102 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> > > index cf23414d7..003f954c2 100644
> > > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> > > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> > > @@ -20,16 +20,16 @@
> > > #define MAX_DOZE_WAITING_TIMES_9x 64
> > >
> > > /**
> > > -* Function: phy_CalculateBitShift
> > > -*
> > > -* OverView: Get shifted position of the BitMask
> > > -*
> > > -* Input:
> > > -* u32 BitMask,
> > > -*
> > > -* Output: none
> > > -* Return: u32 Return the shift bit bit position of the mask
> > > -*/
> > > + * Function: phy_CalculateBitShift
> > > + *
> > > + * OverView: Get shifted position of the BitMask
> > > + *
> > > + * Input:
> > > + * u32 BitMask,
> > > + *
> > > + * Output: none
> > > + * Return: u32 Return the shift bit bit position of the mask
> > > + */
> >
> > These huge function comments are not normal kernel coding style anyway,
> > why not fix them up to use the correct style, don't paper over it and
can you please say it straight?
what exactly do you want me to do?
> > keep this mess around any longer than it needs to be.
what mess? my mails?
> >
> > thanks,
> >
> > greg k-h