From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9201FC433E6 for ; Wed, 10 Feb 2021 16:00:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5095564DE9 for ; Wed, 10 Feb 2021 16:00:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232072AbhBJQAR (ORCPT ); Wed, 10 Feb 2021 11:00:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231984AbhBJP77 (ORCPT ); Wed, 10 Feb 2021 10:59:59 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAA6DC061786 for ; Wed, 10 Feb 2021 07:59:18 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id x136so1539002pfc.2 for ; Wed, 10 Feb 2021 07:59:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RAtFVgzHhLfyixwTlntvq13DCjkeX6xQPOokD6zZ59o=; b=eNbRweMnAvSvlJagkl41Ph0xJKzfdSp0f8fnnQpHRm+GpXtd30L0rk41sjjaq4Is0c V2AhuuF0MtAlk5tHjNDnqfChmmV2+tFHch88/05gzeKz0N0VxVNni21x4S5tKp0UaoA+ /XWb7PG+lhHAmc4M1oxA3Uy2mdD8jxDTWbhk991dBz217RkPYddl6fzSm+ECR9dCqU0+ QqcAWp5Qwp5rYvOYw1oLx9efsTa94jdaMSxCf7x4LgxKVF99sbrJNscv7Bjawpx32ud5 15OcrmyWWeIPVKVUuWKFlZNIovt8bNVU2fEo/PsHkwssUJ6uol0hQd3z3ki+XTNpJXvH PwfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=RAtFVgzHhLfyixwTlntvq13DCjkeX6xQPOokD6zZ59o=; b=D7C63hepAlKXpQzY8G/E5CKB8bvFoo+89NZaE0VIqzpqAtllQEjwxezq/H1wsV29gM tGrGsdwVWL6Y3VPRhQBvJKv0KVcePf5s6b/UYr7q7kUCKHZM5mebiMKEWObJV5dNPTtI KXfpqr5tCSd54H//dKqn/xf9zvQv2rDcaBLjIHrcp/VIcVgAQKgX8SMYpgIkAG1dHcQR 5KoKk1KjPTAMH6ntQvZP3onGDalX1I1eQLGk4HiLJfjnkDSz3bhpxR5N89WscIuaieAM Fy8tiWt/ZWNRJUCgvWuMa+wjjdX3SuYT2tkNiIoOnQjyktNNbpWuZW4jUq9c/alAD1aM fXlw== X-Gm-Message-State: AOAM530um+IeUWfc0JLud26UP9XFZATqquX97+1klS1w6SM52thywdxp FHPI6euuK2AmtU7mE5xCZUI= X-Google-Smtp-Source: ABdhPJwAu19LKeDwjjzO0jCx3QFJ6wmEbRWuzKHKjyHpFzetsD2LeVVswnKzvtX3fLr50am8eqrgkA== X-Received: by 2002:a62:d0c5:0:b029:1d8:61e0:c5ae with SMTP id p188-20020a62d0c50000b02901d861e0c5aemr3662084pfg.52.1612972758275; Wed, 10 Feb 2021 07:59:18 -0800 (PST) Received: from google.com ([2620:15c:211:201:e5b0:be96:1dfb:a1f6]) by smtp.gmail.com with ESMTPSA id o124sm2998887pfg.108.2021.02.10.07.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 07:59:17 -0800 (PST) Sender: Minchan Kim Date: Wed, 10 Feb 2021 07:59:15 -0800 From: Minchan Kim To: John Hubbard Cc: Andrew Morton , willy@infradead.org, gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, LKML , linux-mm Subject: Re: [PATCH v3] mm: cma: support sysfs Message-ID: References: <20210210075509.3788729-1-minchan@kernel.org> <070ca72a-c99f-a2a7-c460-0a823cc262f4@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <070ca72a-c99f-a2a7-c460-0a823cc262f4@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 12:05:48AM -0800, John Hubbard wrote: > On 2/9/21 11:55 PM, Minchan Kim wrote: > > Since CMA is getting used more widely, it's more important to > > keep monitoring CMA statistics for system health since it's > > directly related to user experience. > > > > This patch introduces sysfs statistics for CMA, in order to provide > > some basic monitoring of the CMA allocator. > > > > * the number of CMA page allocation attempts > > * the number of CMA page allocation failures > > > > These two values allow the user to calcuate the allocation > > failure rate for each CMA area. > > > > e.g.) > > /sys/kernel/mm/cma/WIFI/cma_alloc_pages_[attempts|fails] > > /sys/kernel/mm/cma/SENSOR/cma_alloc_pages_[attempts|fails] > > /sys/kernel/mm/cma/BLUETOOTH/cma_alloc_pages_[attempts|fails] > > > > Signed-off-by: Minchan Kim > > --- > > Looks good. > > Reviewed-by: John Hubbard Thanks for reviewing, John and Greg!