From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65E5C433E0 for ; Wed, 10 Feb 2021 20:27:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1C0964EDC for ; Wed, 10 Feb 2021 20:27:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233641AbhBJU13 (ORCPT ); Wed, 10 Feb 2021 15:27:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:46058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233224AbhBJUZl (ORCPT ); Wed, 10 Feb 2021 15:25:41 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7AC5364EDC; Wed, 10 Feb 2021 20:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612988700; bh=4DjTUvBAiW5tn3IwIpk+FPIchSzhXHiwWLN2elYPlQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kAknOCXjfwEYZb+LFXXSG5cqCityyvX266Z8XuMzniespmRCGf7fdJN/2QPZWCh0x YDM7gMkLaKMhbaV1xmkcfPHfTgcyn7CKWlfwUxEFa9/Q57a/ZtYmDeDfb07ZzguYAE L9TVzjDuj3/b0uGx8mTAxKraL1UePP3yf2qEyCsRoqqyZ6s2l+oPGTOZIjdFW6P6HG U73+GlAIRg2AqiMnAFTYyJHImOu0zvWSE9vKGqDX7Kr6fwH2ZXeluakP5pRM86lrz9 J2eP395ADYfbXNynri7Z6vN4iaf+0/6S+cDkPpXEQ1nLhtD7rQIipQOU5YuJpT3WoI p+RRng1ZsPHuw== Date: Wed, 10 Feb 2021 12:24:58 -0800 From: Eric Biggers To: Satya Tangirala Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, Jens Axboe , Mike Snitzer , Alasdair Kergon Subject: Re: [PATCH v4 5/5] dm: set DM_TARGET_PASSES_CRYPTO feature for some targets Message-ID: References: <20210201051019.1174983-1-satyat@google.com> <20210201051019.1174983-6-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210201051019.1174983-6-satyat@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2021 at 05:10:19AM +0000, Satya Tangirala wrote: > dm-linear and dm-flakey obviously can pass through inline crypto support. > > Co-developed-by: Eric Biggers > Signed-off-by: Eric Biggers > Signed-off-by: Satya Tangirala > --- > drivers/md/dm-flakey.c | 4 +++- > drivers/md/dm-linear.c | 5 +++-- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/md/dm-flakey.c b/drivers/md/dm-flakey.c > index a2cc9e45cbba..30c6bc151213 100644 > --- a/drivers/md/dm-flakey.c > +++ b/drivers/md/dm-flakey.c > @@ -482,8 +482,10 @@ static struct target_type flakey_target = { > .name = "flakey", > .version = {1, 5, 0}, > #ifdef CONFIG_BLK_DEV_ZONED > - .features = DM_TARGET_ZONED_HM, > + .features = DM_TARGET_ZONED_HM | DM_TARGET_PASSES_CRYPTO, > .report_zones = flakey_report_zones, > +#else > + .features = DM_TARGET_PASSES_CRYPTO, > #endif > .module = THIS_MODULE, > .ctr = flakey_ctr, > diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c > index 00774b5d7668..fc9c4272c10d 100644 > --- a/drivers/md/dm-linear.c > +++ b/drivers/md/dm-linear.c > @@ -229,10 +229,11 @@ static struct target_type linear_target = { > .version = {1, 4, 0}, > #ifdef CONFIG_BLK_DEV_ZONED > .features = DM_TARGET_PASSES_INTEGRITY | DM_TARGET_NOWAIT | > - DM_TARGET_ZONED_HM, > + DM_TARGET_ZONED_HM | DM_TARGET_PASSES_CRYPTO, > .report_zones = linear_report_zones, > #else > - .features = DM_TARGET_PASSES_INTEGRITY | DM_TARGET_NOWAIT, > + .features = DM_TARGET_PASSES_INTEGRITY | DM_TARGET_NOWAIT | > + DM_TARGET_PASSES_CRYPTO, > #endif > .module = THIS_MODULE, > .ctr = linear_ctr, > -- This latest version looks good to me. If it's needed despite my Co-developed-by, feel free to add: Reviewed-by: Eric Biggers BTW, the #ifdef for CONFIG_BLK_DEV_ZONED is error-prone (though it's a pre-existing issue). I wonder if DM_TARGET_ZONED_HM should be defined to 0 when !CONFIG_BLK_DEV_ZONED, which would avoid the need for the #ifdef on .features. - Eric