From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDBD7C433E0 for ; Thu, 11 Feb 2021 13:13:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA5C764DDA for ; Thu, 11 Feb 2021 13:13:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230482AbhBKNNl (ORCPT ); Thu, 11 Feb 2021 08:13:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:57108 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231235AbhBKMxg (ORCPT ); Thu, 11 Feb 2021 07:53:36 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5C56264E23; Thu, 11 Feb 2021 12:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613047975; bh=99I1eozXtWkXvuBKVv7ThLgqy2gpI2q85GrISahxQiU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mQ9bXOKr3KZCPJeXvS20XhnouoncNYole1tutv+OrzcfjYkGCyaL8mZfNqfLr1bZi fQf40rqik4EB49L30y5uYHGj3mnZradcwhKRRBtz0xZYD9AO9xVPtFi5a0XzKjyc6O Mcc3rxAhYoq2BrqEXULKnPj8zdLKSPmZT5M2lQYI= Date: Thu, 11 Feb 2021 13:52:53 +0100 From: Greg KH To: Fatih Yildirim Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gustavo@embeddedor.com Subject: Re: [PATCH -next] staging: ks7010: Macros with complex values Message-ID: References: <20210211092239.10291-1-yildirim.fatih@gmail.com> <20210211105704.GA10351@TRWS9215.usr.ingenico.loc> <20210211122324.GA10415@TRWS9215.usr.ingenico.loc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210211122324.GA10415@TRWS9215.usr.ingenico.loc> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2021 at 03:23:24PM +0300, Fatih Yildirim wrote: > On Thu, Feb 11, 2021 at 12:10:44PM +0100, Greg KH wrote: > > On Thu, Feb 11, 2021 at 01:57:04PM +0300, Fatih YILDIRIM wrote: > > > On Thu, Feb 11, 2021 at 11:02:51AM +0100, Greg KH wrote: > > > > On Thu, Feb 11, 2021 at 12:22:39PM +0300, Fatih Yildirim wrote: > > > > > Fix for checkpatch.pl warning: > > > > > Macros with complex values should be enclosed in parentheses. > > > > > > > > > > Signed-off-by: Fatih Yildirim > > > > > --- > > > > > drivers/staging/ks7010/ks_hostif.h | 24 ++++++++++++------------ > > > > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > > > > > > > diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h > > > > > index 39138191a556..c62a494ed6bb 100644 > > > > > --- a/drivers/staging/ks7010/ks_hostif.h > > > > > +++ b/drivers/staging/ks7010/ks_hostif.h > > > > > @@ -498,20 +498,20 @@ struct hostif_mic_failure_request { > > > > > #define TX_RATE_FIXED 5 > > > > > > > > > > /* 11b rate */ > > > > > -#define TX_RATE_1M (u8)(10 / 5) /* 11b 11g basic rate */ > > > > > -#define TX_RATE_2M (u8)(20 / 5) /* 11b 11g basic rate */ > > > > > -#define TX_RATE_5M (u8)(55 / 5) /* 11g basic rate */ > > > > > -#define TX_RATE_11M (u8)(110 / 5) /* 11g basic rate */ > > > > > +#define TX_RATE_1M ((u8)(10 / 5)) /* 11b 11g basic rate */ > > > > > +#define TX_RATE_2M ((u8)(20 / 5)) /* 11b 11g basic rate */ > > > > > +#define TX_RATE_5M ((u8)(55 / 5)) /* 11g basic rate */ > > > > > +#define TX_RATE_11M ((u8)(110 / 5)) /* 11g basic rate */ > > > > > > > > But these are not "complex macros" that need an extra () added to them, > > > > right? > > > > > > > > Checkpatch is a hint, it's not a code parser and can not always know > > > > what is happening. With your knowledge of C, does this look like > > > > something that needs to be "fixed"? > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Hi Greg, > > > > > > Thanks for your reply. > > > Actually, I'm following the Eudyptula Challenge and I'm at task 10. > > > > First rule of that challenge is that you are not allowed to talk about > > it in public :) > > > > That being said, you didn't answer any of my questions above :( > > > > greg k-h > > Ohh no, missed the rule. Sorry for that, I feel rookie :) > You are right, they are not complex macros. > Besides that, type cast operator doesn't have the highest precedence. > So, I think we can use enclosing paranthesis. I don't think they are needed, see how these are used please. thanks, greg k-h