From: Jiri Olsa <jolsa@redhat.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf env: Remove unneeded internal/cpumap inclusions
Date: Fri, 12 Feb 2021 09:33:45 +0100 [thread overview]
Message-ID: <YCY9aTcEMS1pFP6+@krava> (raw)
In-Reply-To: <20210211183914.4093187-1-irogers@google.com>
On Thu, Feb 11, 2021 at 10:39:14AM -0800, Ian Rogers wrote:
> Minor cleanup.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> ---
> tools/perf/bench/epoll-ctl.c | 1 -
> tools/perf/bench/epoll-wait.c | 1 -
> tools/perf/bench/futex-hash.c | 1 -
> tools/perf/bench/futex-lock-pi.c | 1 -
> tools/perf/bench/futex-requeue.c | 1 -
> tools/perf/bench/futex-wake-parallel.c | 1 -
> tools/perf/bench/futex-wake.c | 1 -
> tools/perf/tests/openat-syscall-all-cpus.c | 1 -
> tools/perf/util/synthetic-events.c | 1 -
> 9 files changed, 9 deletions(-)
>
> diff --git a/tools/perf/bench/epoll-ctl.c b/tools/perf/bench/epoll-ctl.c
> index ca2d591aad8a..ddaca75c3bc0 100644
> --- a/tools/perf/bench/epoll-ctl.c
> +++ b/tools/perf/bench/epoll-ctl.c
> @@ -21,7 +21,6 @@
> #include <sys/resource.h>
> #include <sys/epoll.h>
> #include <sys/eventfd.h>
> -#include <internal/cpumap.h>
> #include <perf/cpumap.h>
>
> #include "../util/stat.h"
> diff --git a/tools/perf/bench/epoll-wait.c b/tools/perf/bench/epoll-wait.c
> index 75dca9773186..0a0ff1247c83 100644
> --- a/tools/perf/bench/epoll-wait.c
> +++ b/tools/perf/bench/epoll-wait.c
> @@ -76,7 +76,6 @@
> #include <sys/epoll.h>
> #include <sys/eventfd.h>
> #include <sys/types.h>
> -#include <internal/cpumap.h>
> #include <perf/cpumap.h>
>
> #include "../util/stat.h"
> diff --git a/tools/perf/bench/futex-hash.c b/tools/perf/bench/futex-hash.c
> index 915bf3da7ce2..b65373ce5c4f 100644
> --- a/tools/perf/bench/futex-hash.c
> +++ b/tools/perf/bench/futex-hash.c
> @@ -20,7 +20,6 @@
> #include <linux/kernel.h>
> #include <linux/zalloc.h>
> #include <sys/time.h>
> -#include <internal/cpumap.h>
> #include <perf/cpumap.h>
>
> #include "../util/stat.h"
> diff --git a/tools/perf/bench/futex-lock-pi.c b/tools/perf/bench/futex-lock-pi.c
> index bb25d8beb3b8..89c6d160379c 100644
> --- a/tools/perf/bench/futex-lock-pi.c
> +++ b/tools/perf/bench/futex-lock-pi.c
> @@ -14,7 +14,6 @@
> #include <linux/kernel.h>
> #include <linux/zalloc.h>
> #include <errno.h>
> -#include <internal/cpumap.h>
> #include <perf/cpumap.h>
> #include "bench.h"
> #include "futex.h"
> diff --git a/tools/perf/bench/futex-requeue.c b/tools/perf/bench/futex-requeue.c
> index 7a15c2e61022..5fa23295ee5f 100644
> --- a/tools/perf/bench/futex-requeue.c
> +++ b/tools/perf/bench/futex-requeue.c
> @@ -20,7 +20,6 @@
> #include <linux/kernel.h>
> #include <linux/time64.h>
> #include <errno.h>
> -#include <internal/cpumap.h>
> #include <perf/cpumap.h>
> #include "bench.h"
> #include "futex.h"
> diff --git a/tools/perf/bench/futex-wake-parallel.c b/tools/perf/bench/futex-wake-parallel.c
> index cd2b81a845ac..6e6f5247e1fe 100644
> --- a/tools/perf/bench/futex-wake-parallel.c
> +++ b/tools/perf/bench/futex-wake-parallel.c
> @@ -29,7 +29,6 @@ int bench_futex_wake_parallel(int argc __maybe_unused, const char **argv __maybe
> #include <linux/time64.h>
> #include <errno.h>
> #include "futex.h"
> -#include <internal/cpumap.h>
> #include <perf/cpumap.h>
>
> #include <err.h>
> diff --git a/tools/perf/bench/futex-wake.c b/tools/perf/bench/futex-wake.c
> index 2dfcef3e371e..6d217868f53c 100644
> --- a/tools/perf/bench/futex-wake.c
> +++ b/tools/perf/bench/futex-wake.c
> @@ -20,7 +20,6 @@
> #include <linux/kernel.h>
> #include <linux/time64.h>
> #include <errno.h>
> -#include <internal/cpumap.h>
> #include <perf/cpumap.h>
> #include "bench.h"
> #include "futex.h"
> diff --git a/tools/perf/tests/openat-syscall-all-cpus.c b/tools/perf/tests/openat-syscall-all-cpus.c
> index 71f85e2cc127..f7dd6c463f04 100644
> --- a/tools/perf/tests/openat-syscall-all-cpus.c
> +++ b/tools/perf/tests/openat-syscall-all-cpus.c
> @@ -15,7 +15,6 @@
> #include "tests.h"
> #include "thread_map.h"
> #include <perf/cpumap.h>
> -#include <internal/cpumap.h>
> #include "debug.h"
> #include "stat.h"
> #include "util/counts.h"
> diff --git a/tools/perf/util/synthetic-events.c b/tools/perf/util/synthetic-events.c
> index c6f9db3faf83..0b767233ae1f 100644
> --- a/tools/perf/util/synthetic-events.c
> +++ b/tools/perf/util/synthetic-events.c
> @@ -24,7 +24,6 @@
> #include <linux/perf_event.h>
> #include <asm/bug.h>
> #include <perf/evsel.h>
> -#include <internal/cpumap.h>
> #include <perf/cpumap.h>
> #include <internal/lib.h> // page_size
> #include <internal/threadmap.h>
> --
> 2.30.0.478.g8a0d178c01-goog
>
next prev parent reply other threads:[~2021-02-12 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 18:39 [PATCH] perf env: Remove unneeded internal/cpumap inclusions Ian Rogers
2021-02-12 8:33 ` Jiri Olsa [this message]
2021-02-12 20:36 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCY9aTcEMS1pFP6+@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox