From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 386FAC433DB for ; Fri, 12 Feb 2021 07:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0857E64E65 for ; Fri, 12 Feb 2021 07:43:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbhBLHm6 (ORCPT ); Fri, 12 Feb 2021 02:42:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:45200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbhBLHlG (ORCPT ); Fri, 12 Feb 2021 02:41:06 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id AF10A64E57; Fri, 12 Feb 2021 07:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613115626; bh=NC6YL/6c8hJFmodCo5hFzbMLG6Jhztdn+/HB+CRRdFI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pmGRKEYfXn3dX7fVPgbjy4Aq/RSm1K7+yuGXjrPC5APBdSEM7QjKIAbNIM0HfdB4f 8QIWnU5A+MfAXmWTH6vqE4l3SzXd9AWp8KONehtSnilSLdauE0Rbr9JeQOcOi6EECn fbIclQBahW+Z8Nhrn+1aQaPkM4hHkEOyhifSVrQA= Date: Fri, 12 Feb 2021 08:40:23 +0100 From: Greg KH To: min.li.xe@renesas.com Cc: derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support Message-ID: References: <1613092575-17311-1-git-send-email-min.li.xe@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1613092575-17311-1-git-send-email-min.li.xe@renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2021 at 08:16:15PM -0500, min.li.xe@renesas.com wrote: > From: Min Li > > This driver supports 1588 related functions of ClockMatrix(TM) > and 82P33xxx families of timing and synchronization devices. > > The driver is developed to be only used by Renesas PTP Clock > Manager for Linux (pcm4l) software. It supports 1588/PTP > releated functionalities that specific to Renesas devices > but are not supported by general PHC framework. So pcm4l > will use both the existing PHC driver and this module to > complete 1588/PTP support. The supported functons are: > > -set combomode > -get dpll's state > -get dpll's ffo > > This driver must work with Renesas MFD driver to access SMU > through I2C/SPI. > > Changes since v1: > -Provide more background for purpose of the change. > -Provide compat_ioctl support > -Fix ioctl cmd definition This "changes" list goes below the --- line. And you seem to have ignored my review, especially about documenting the sysfs files here, please do that as I can not accept this patch as-is. greg k-h