From: Greg KH <gregkh@linuxfoundation.org>
To: min.li.xe@renesas.com
Cc: derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com,
arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support
Date: Fri, 12 Feb 2021 08:39:24 +0100 [thread overview]
Message-ID: <YCYwrNE8547uuODo@kroah.com> (raw)
In-Reply-To: <1613092575-17311-1-git-send-email-min.li.xe@renesas.com>
On Thu, Feb 11, 2021 at 08:16:15PM -0500, min.li.xe@renesas.com wrote:
> +static int
> +rsmu_open(struct inode *iptr, struct file *fptr)
> +{
> + struct rsmu_cdev *rsmu;
> +
> + rsmu = container_of(iptr->i_cdev, struct rsmu_cdev, rsmu_cdev);
> + if (!rsmu)
> + return -EAGAIN;
> +
> + /* Only one open per device at a time */
> + if (!atomic_dec_and_test(&rsmu->open_count)) {
> + atomic_inc(&rsmu->open_count);
> + return -EBUSY;
This does not do what you think it does, and does not prevent multiple
applications from talking to your device at the same time.
There is no need for this at all, as it does not work, sorry. If
multiple apps talk to your device, it's their fault, not the kernel's
fault, that things go wrong.
And I thought that Arnd already told you to fix this?
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-12 7:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 1:16 [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support min.li.xe
2021-02-12 7:39 ` Greg KH [this message]
2021-02-12 15:39 ` Min Li
2021-02-12 15:48 ` Greg KH
2021-02-12 16:02 ` Min Li
2021-02-12 16:22 ` Greg KH
2021-02-12 7:40 ` Greg KH
2021-02-12 15:44 ` Min Li
2021-02-12 15:55 ` Greg KH
2021-02-12 16:04 ` Min Li
2021-02-12 19:06 ` Min Li
2021-02-13 8:28 ` Greg KH
2021-02-16 19:50 ` Min Li
2021-02-17 7:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCYwrNE8547uuODo@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox