* [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c @ 2021-02-12 8:18 Pritthijit Nath 2021-02-12 8:18 ` [PATCH 2/2] staging: greybus: Fixed a misspelling " Pritthijit Nath 2021-02-12 9:09 ` [PATCH 1/2] staging: greybus: Fixed alignment issue " Viresh Kumar 0 siblings, 2 replies; 12+ messages in thread From: Pritthijit Nath @ 2021-02-12 8:18 UTC (permalink / raw) To: vireshk, gregkh, johan, elder Cc: greybus-dev, devel, linux-kernel, Pritthijit Nath This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis". Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> --- drivers/staging/greybus/hid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c index ed706f39e87a..a56c3fb5d35a 100644 --- a/drivers/staging/greybus/hid.c +++ b/drivers/staging/greybus/hid.c @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid) } static int __gb_hid_get_raw_report(struct hid_device *hid, - unsigned char report_number, __u8 *buf, size_t count, - unsigned char report_type) + unsigned char report_number, __u8 *buf, size_t count, + unsigned char report_type) { struct gb_hid *ghid = hid->driver_data; int ret; -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c 2021-02-12 8:18 [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c Pritthijit Nath @ 2021-02-12 8:18 ` Pritthijit Nath 2021-02-12 8:44 ` Johan Hovold 2021-02-12 9:09 ` [PATCH 1/2] staging: greybus: Fixed alignment issue " Viresh Kumar 1 sibling, 1 reply; 12+ messages in thread From: Pritthijit Nath @ 2021-02-12 8:18 UTC (permalink / raw) To: vireshk, gregkh, johan, elder Cc: greybus-dev, devel, linux-kernel, Pritthijit Nath Fixed the spelling of 'transfered' to 'transferred'. Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> --- drivers/staging/greybus/hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c index a56c3fb5d35a..6b19ff4743a9 100644 --- a/drivers/staging/greybus/hid.c +++ b/drivers/staging/greybus/hid.c @@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf, ret = gb_hid_set_report(ghid, report_type, report_id, buf, len); if (report_id && ret >= 0) - ret++; /* add report_id to the number of transfered bytes */ + ret++; /* add report_id to the number of transferrid bytes */ return 0; } -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c 2021-02-12 8:18 ` [PATCH 2/2] staging: greybus: Fixed a misspelling " Pritthijit Nath @ 2021-02-12 8:44 ` Johan Hovold 2021-02-12 8:54 ` Greg KH 0 siblings, 1 reply; 12+ messages in thread From: Johan Hovold @ 2021-02-12 8:44 UTC (permalink / raw) To: Pritthijit Nath; +Cc: vireshk, gregkh, elder, greybus-dev, devel, linux-kernel On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote: > Fixed the spelling of 'transfered' to 'transferred'. > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> > --- > drivers/staging/greybus/hid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c > index a56c3fb5d35a..6b19ff4743a9 100644 > --- a/drivers/staging/greybus/hid.c > +++ b/drivers/staging/greybus/hid.c > @@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf, > > ret = gb_hid_set_report(ghid, report_type, report_id, buf, len); > if (report_id && ret >= 0) > - ret++; /* add report_id to the number of transfered bytes */ > + ret++; /* add report_id to the number of transferrid bytes */ You now misspelled transferred in a different way. > > return 0; > } Johan ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c 2021-02-12 8:44 ` Johan Hovold @ 2021-02-12 8:54 ` Greg KH 2021-02-12 9:07 ` Viresh Kumar 0 siblings, 1 reply; 12+ messages in thread From: Greg KH @ 2021-02-12 8:54 UTC (permalink / raw) To: Johan Hovold Cc: Pritthijit Nath, devel, elder, vireshk, linux-kernel, greybus-dev On Fri, Feb 12, 2021 at 09:44:04AM +0100, Johan Hovold wrote: > On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote: > > Fixed the spelling of 'transfered' to 'transferred'. > > > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> > > --- > > drivers/staging/greybus/hid.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c > > index a56c3fb5d35a..6b19ff4743a9 100644 > > --- a/drivers/staging/greybus/hid.c > > +++ b/drivers/staging/greybus/hid.c > > @@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf, > > > > ret = gb_hid_set_report(ghid, report_type, report_id, buf, len); > > if (report_id && ret >= 0) > > - ret++; /* add report_id to the number of transfered bytes */ > > + ret++; /* add report_id to the number of transferrid bytes */ > > You now misspelled transferred in a different way. Oops, will go revert this, I need more coffee... ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c 2021-02-12 8:54 ` Greg KH @ 2021-02-12 9:07 ` Viresh Kumar 0 siblings, 0 replies; 12+ messages in thread From: Viresh Kumar @ 2021-02-12 9:07 UTC (permalink / raw) To: Greg KH Cc: Johan Hovold, Pritthijit Nath, devel, elder, vireshk, linux-kernel, greybus-dev On 12-02-21, 09:54, Greg KH wrote: > On Fri, Feb 12, 2021 at 09:44:04AM +0100, Johan Hovold wrote: > > On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote: > > > Fixed the spelling of 'transfered' to 'transferred'. > > > > > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> > > > --- > > > drivers/staging/greybus/hid.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c > > > index a56c3fb5d35a..6b19ff4743a9 100644 > > > --- a/drivers/staging/greybus/hid.c > > > +++ b/drivers/staging/greybus/hid.c > > > @@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf, > > > > > > ret = gb_hid_set_report(ghid, report_type, report_id, buf, len); > > > if (report_id && ret >= 0) > > > - ret++; /* add report_id to the number of transfered bytes */ > > > + ret++; /* add report_id to the number of transferrid bytes */ > > > > You now misspelled transferred in a different way. > > Oops, will go revert this, I need more coffee... Yeah, its Friday.. You need a break too :) -- viresh ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c 2021-02-12 8:18 [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c Pritthijit Nath 2021-02-12 8:18 ` [PATCH 2/2] staging: greybus: Fixed a misspelling " Pritthijit Nath @ 2021-02-12 9:09 ` Viresh Kumar 2021-02-12 9:17 ` Greg KH 1 sibling, 1 reply; 12+ messages in thread From: Viresh Kumar @ 2021-02-12 9:09 UTC (permalink / raw) To: Pritthijit Nath Cc: vireshk, gregkh, johan, elder, greybus-dev, devel, linux-kernel On 12-02-21, 13:48, Pritthijit Nath wrote: > This change fixes a checkpatch CHECK style issue for "Alignment should match > open parenthesis". > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> > --- > drivers/staging/greybus/hid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c > index ed706f39e87a..a56c3fb5d35a 100644 > --- a/drivers/staging/greybus/hid.c > +++ b/drivers/staging/greybus/hid.c > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid) > } > > static int __gb_hid_get_raw_report(struct hid_device *hid, > - unsigned char report_number, __u8 *buf, size_t count, > - unsigned char report_type) > + unsigned char report_number, __u8 *buf, size_t count, > + unsigned char report_type) > { > struct gb_hid *ghid = hid->driver_data; > int ret; I can't even count the number of attempts we have seen in previous years to make checkpatch --strict happy for greybus. I say we make this change once and for all across greybus, so we don't have to review or NAK someone afterwards. Should I send a patch for this ? -- viresh ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c 2021-02-12 9:09 ` [PATCH 1/2] staging: greybus: Fixed alignment issue " Viresh Kumar @ 2021-02-12 9:17 ` Greg KH 2021-02-12 9:21 ` Viresh Kumar 0 siblings, 1 reply; 12+ messages in thread From: Greg KH @ 2021-02-12 9:17 UTC (permalink / raw) To: Viresh Kumar Cc: Pritthijit Nath, devel, elder, vireshk, johan, linux-kernel, greybus-dev On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote: > On 12-02-21, 13:48, Pritthijit Nath wrote: > > This change fixes a checkpatch CHECK style issue for "Alignment should match > > open parenthesis". > > > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> > > --- > > drivers/staging/greybus/hid.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c > > index ed706f39e87a..a56c3fb5d35a 100644 > > --- a/drivers/staging/greybus/hid.c > > +++ b/drivers/staging/greybus/hid.c > > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid) > > } > > > > static int __gb_hid_get_raw_report(struct hid_device *hid, > > - unsigned char report_number, __u8 *buf, size_t count, > > - unsigned char report_type) > > + unsigned char report_number, __u8 *buf, size_t count, > > + unsigned char report_type) > > { > > struct gb_hid *ghid = hid->driver_data; > > int ret; > > I can't even count the number of attempts we have seen in previous > years to make checkpatch --strict happy for greybus. > > I say we make this change once and for all across greybus, so we don't > have to review or NAK someone afterwards. > > Should I send a patch for this ? Sure, but note that over time, checkpatch adds new things so there will always be something to change in here, until we move it out of the drivers/staging/ area :) I need to go fix up the greybus vibrator patch which was my first attempt at getting back into that effort... thanks, greg k-h ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c 2021-02-12 9:17 ` Greg KH @ 2021-02-12 9:21 ` Viresh Kumar 2021-02-12 9:36 ` Greg KH 2021-02-12 9:52 ` Johan Hovold 0 siblings, 2 replies; 12+ messages in thread From: Viresh Kumar @ 2021-02-12 9:21 UTC (permalink / raw) To: Greg KH Cc: Pritthijit Nath, devel, elder, vireshk, johan, linux-kernel, greybus-dev On 12-02-21, 10:17, Greg KH wrote: > On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote: > > On 12-02-21, 13:48, Pritthijit Nath wrote: > > > This change fixes a checkpatch CHECK style issue for "Alignment should match > > > open parenthesis". > > > > > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> > > > --- > > > drivers/staging/greybus/hid.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c > > > index ed706f39e87a..a56c3fb5d35a 100644 > > > --- a/drivers/staging/greybus/hid.c > > > +++ b/drivers/staging/greybus/hid.c > > > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid) > > > } > > > > > > static int __gb_hid_get_raw_report(struct hid_device *hid, > > > - unsigned char report_number, __u8 *buf, size_t count, > > > - unsigned char report_type) > > > + unsigned char report_number, __u8 *buf, size_t count, > > > + unsigned char report_type) > > > { > > > struct gb_hid *ghid = hid->driver_data; > > > int ret; > > > > I can't even count the number of attempts we have seen in previous > > years to make checkpatch --strict happy for greybus. > > > > I say we make this change once and for all across greybus, so we don't > > have to review or NAK someone afterwards. > > > > Should I send a patch for this ? > > Sure, but note that over time, checkpatch adds new things so there will > always be something to change in here, until we move it out of the > drivers/staging/ area :) Right, though I wasn't worried about other checkpatch warning but specially the "alignment - parenthesis" one. Everyone (specially newbies) want to fix that everywhere :) -- viresh ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c 2021-02-12 9:21 ` Viresh Kumar @ 2021-02-12 9:36 ` Greg KH 2021-02-12 9:52 ` Johan Hovold 1 sibling, 0 replies; 12+ messages in thread From: Greg KH @ 2021-02-12 9:36 UTC (permalink / raw) To: Viresh Kumar Cc: devel, elder, vireshk, johan, linux-kernel, greybus-dev, Pritthijit Nath On Fri, Feb 12, 2021 at 02:51:30PM +0530, Viresh Kumar wrote: > On 12-02-21, 10:17, Greg KH wrote: > > On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote: > > > On 12-02-21, 13:48, Pritthijit Nath wrote: > > > > This change fixes a checkpatch CHECK style issue for "Alignment should match > > > > open parenthesis". > > > > > > > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> > > > > --- > > > > drivers/staging/greybus/hid.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c > > > > index ed706f39e87a..a56c3fb5d35a 100644 > > > > --- a/drivers/staging/greybus/hid.c > > > > +++ b/drivers/staging/greybus/hid.c > > > > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid) > > > > } > > > > > > > > static int __gb_hid_get_raw_report(struct hid_device *hid, > > > > - unsigned char report_number, __u8 *buf, size_t count, > > > > - unsigned char report_type) > > > > + unsigned char report_number, __u8 *buf, size_t count, > > > > + unsigned char report_type) > > > > { > > > > struct gb_hid *ghid = hid->driver_data; > > > > int ret; > > > > > > I can't even count the number of attempts we have seen in previous > > > years to make checkpatch --strict happy for greybus. > > > > > > I say we make this change once and for all across greybus, so we don't > > > have to review or NAK someone afterwards. > > > > > > Should I send a patch for this ? > > > > Sure, but note that over time, checkpatch adds new things so there will > > always be something to change in here, until we move it out of the > > drivers/staging/ area :) > > Right, though I wasn't worried about other checkpatch warning but > specially the "alignment - parenthesis" one. Everyone (specially > newbies) want to fix that everywhere :) Sure, fix it up "right" if you want to, I'll take coding style fixes from anyone :) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c 2021-02-12 9:21 ` Viresh Kumar 2021-02-12 9:36 ` Greg KH @ 2021-02-12 9:52 ` Johan Hovold 2021-02-12 9:55 ` Viresh Kumar 1 sibling, 1 reply; 12+ messages in thread From: Johan Hovold @ 2021-02-12 9:52 UTC (permalink / raw) To: Viresh Kumar Cc: Greg KH, Pritthijit Nath, devel, elder, vireshk, linux-kernel, greybus-dev On Fri, Feb 12, 2021 at 02:51:30PM +0530, Viresh Kumar wrote: > On 12-02-21, 10:17, Greg KH wrote: > > On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote: > > > On 12-02-21, 13:48, Pritthijit Nath wrote: > > > > This change fixes a checkpatch CHECK style issue for "Alignment should match > > > > open parenthesis". > > > > > > > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com> > > > > --- > > > > drivers/staging/greybus/hid.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c > > > > index ed706f39e87a..a56c3fb5d35a 100644 > > > > --- a/drivers/staging/greybus/hid.c > > > > +++ b/drivers/staging/greybus/hid.c > > > > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid) > > > > } > > > > > > > > static int __gb_hid_get_raw_report(struct hid_device *hid, > > > > - unsigned char report_number, __u8 *buf, size_t count, > > > > - unsigned char report_type) > > > > + unsigned char report_number, __u8 *buf, size_t count, > > > > + unsigned char report_type) > > > > { > > > > struct gb_hid *ghid = hid->driver_data; > > > > int ret; > > > > > > I can't even count the number of attempts we have seen in previous > > > years to make checkpatch --strict happy for greybus. > > > > > > I say we make this change once and for all across greybus, so we don't > > > have to review or NAK someone afterwards. > > > > > > Should I send a patch for this ? > > > > Sure, but note that over time, checkpatch adds new things so there will > > always be something to change in here, until we move it out of the > > drivers/staging/ area :) > > Right, though I wasn't worried about other checkpatch warning but > specially the "alignment - parenthesis" one. Everyone (specially > newbies) want to fix that everywhere :) But what will the checkpatch crew then work on? Better staging than the rest of the kernel. Perhaps just let them keep at it until we move the rest out (the price we pay for taking this through staging apparently). But there can't be that many instances left of this alignment "violation" in staging/greybus (~4 it seems) if you want to get it over with. Johan ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c 2021-02-12 9:52 ` Johan Hovold @ 2021-02-12 9:55 ` Viresh Kumar 2021-02-12 10:06 ` Johan Hovold 0 siblings, 1 reply; 12+ messages in thread From: Viresh Kumar @ 2021-02-12 9:55 UTC (permalink / raw) To: Johan Hovold Cc: Greg KH, Pritthijit Nath, devel, elder, vireshk, linux-kernel, greybus-dev On 12-02-21, 10:52, Johan Hovold wrote: > But what will the checkpatch crew then work on? Lol.. > Better staging than the rest of the kernel. [ /me wondering on who stops them from sending patches for rest of the kernel ? ] -- viresh ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c 2021-02-12 9:55 ` Viresh Kumar @ 2021-02-12 10:06 ` Johan Hovold 0 siblings, 0 replies; 12+ messages in thread From: Johan Hovold @ 2021-02-12 10:06 UTC (permalink / raw) To: Viresh Kumar Cc: Greg KH, Pritthijit Nath, devel, elder, vireshk, linux-kernel, greybus-dev On Fri, Feb 12, 2021 at 03:25:29PM +0530, Viresh Kumar wrote: > On 12-02-21, 10:52, Johan Hovold wrote: > > But what will the checkpatch crew then work on? > > Lol.. > > > Better staging than the rest of the kernel. > > [ /me wondering on who stops them from sending patches for rest of the > kernel ? ] Ideally maintainers should at least push back when they do. Johan ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-02-12 10:07 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-02-12 8:18 [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c Pritthijit Nath 2021-02-12 8:18 ` [PATCH 2/2] staging: greybus: Fixed a misspelling " Pritthijit Nath 2021-02-12 8:44 ` Johan Hovold 2021-02-12 8:54 ` Greg KH 2021-02-12 9:07 ` Viresh Kumar 2021-02-12 9:09 ` [PATCH 1/2] staging: greybus: Fixed alignment issue " Viresh Kumar 2021-02-12 9:17 ` Greg KH 2021-02-12 9:21 ` Viresh Kumar 2021-02-12 9:36 ` Greg KH 2021-02-12 9:52 ` Johan Hovold 2021-02-12 9:55 ` Viresh Kumar 2021-02-12 10:06 ` Johan Hovold
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox