From: Greg KH <gregkh@linuxfoundation.org>
To: Mihai Carabas <mihai.carabas@oracle.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
rdunlap@infradead.org, bobo.shaobowang@huawei.com
Subject: Re: [PATCH v2 2/3] misc/pvpanic: add PCI driver
Date: Fri, 12 Feb 2021 11:18:09 +0100 [thread overview]
Message-ID: <YCZV4ZNgvP0GfjVF@kroah.com> (raw)
In-Reply-To: <1613121426-15585-3-git-send-email-mihai.carabas@oracle.com>
On Fri, Feb 12, 2021 at 11:17:05AM +0200, Mihai Carabas wrote:
> Add support for pvpanic PCI device added in qemu [1]. At probe time, obtain the
> address where to read/write pvpanic events and pass it to the generic handling
> code. Will follow the same logic as pvpanic MMIO device driver. At remove time,
> unmap base address and disable PCI device.
>
> [1] https://github.com/qemu/qemu/commit/9df52f58e76e904fb141b10318362d718f470db2
>
> Signed-off-by: Mihai Carabas <mihai.carabas@oracle.com>
> ---
> drivers/misc/pvpanic/Kconfig | 8 +++++++
> drivers/misc/pvpanic/Makefile | 2 ++
> drivers/misc/pvpanic/pci.c | 49 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 59 insertions(+)
> create mode 100644 drivers/misc/pvpanic/pci.c
>
> diff --git a/drivers/misc/pvpanic/Kconfig b/drivers/misc/pvpanic/Kconfig
> index 0dce6ef..ce8b93e 100644
> --- a/drivers/misc/pvpanic/Kconfig
> +++ b/drivers/misc/pvpanic/Kconfig
> @@ -10,3 +10,11 @@ config PVPANIC_MMIO
> This driver provides support for the pvpanic device. pvpanic is
> a paravirtualized device provided by QEMU; it lets a virtual machine
> (guest) communicate panic events to the host.
> +
> +config PVPANIC_PCI
> + tristate "pvpanic PCI device support"
> + depends on PCI && PVPANIC
> + help
> + This driver provides support for the pvpanic device. pvpanic is
> + a paravirtualized device provided by QEMU; it lets a virtual machine
> + (guest) communicate panic events to the host.
> diff --git a/drivers/misc/pvpanic/Makefile b/drivers/misc/pvpanic/Makefile
> index 9ea3355..1763450 100644
> --- a/drivers/misc/pvpanic/Makefile
> +++ b/drivers/misc/pvpanic/Makefile
> @@ -1,2 +1,4 @@
> obj-$(CONFIG_PVPANIC_MMIO) += pvpanic-mmio.o
> pvpanic-mmio-objs := pvpanic-common.o mmio.o
> +obj-$(CONFIG_PVPANIC_PCI) += pvpanic-pci.o
> +pvpanic-pci-objs := pvpanic-common.o pci.o
So you now have the pvpanic-common.o file linked into both modules at
the same time? What happens if they are both loaded?
This feels really broken...
greg k-h
next prev parent reply other threads:[~2021-02-12 10:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 9:17 [PATCH v2] add support for pci in the pvpanic driver Mihai Carabas
2021-02-12 9:17 ` [PATCH v2 1/3] misc/pvpanic: split-up generic and platform dependent code Mihai Carabas
2021-02-12 10:12 ` Arnd Bergmann
2021-02-12 10:17 ` Greg KH
2021-02-12 10:29 ` Mihai Carabas
2021-02-12 11:00 ` Greg KH
2021-02-12 12:26 ` kernel test robot
2021-02-12 9:17 ` [PATCH v2 2/3] misc/pvpanic: add PCI driver Mihai Carabas
2021-02-12 10:15 ` Arnd Bergmann
2021-02-12 10:18 ` Greg KH [this message]
2021-02-12 10:23 ` Arnd Bergmann
2021-02-12 9:17 ` [PATCH v2 3/3] misc/pvpanic: add license Mihai Carabas
2021-02-12 10:13 ` Arnd Bergmann
2021-02-12 10:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCZV4ZNgvP0GfjVF@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bobo.shaobowang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.carabas@oracle.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox