From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thais Camacho <thaiscamachoo@gmail.com>
Cc: devel@driverdev.osuosl.org, "Todd Kjos" <tkjos@android.com>,
linux-kernel@vger.kernel.org,
"Hridya Valsaraju" <hridya@google.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Martijn Coenen" <maco@android.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Christian Brauner" <christian@brauner.io>
Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword
Date: Sun, 14 Feb 2021 09:21:33 +0100 [thread overview]
Message-ID: <YCjdjdjcdXRUMhU/@kroah.com> (raw)
In-Reply-To: <20210214023136.8916-1-thaiscamachoo@gmail.com>
On Sat, Feb 13, 2021 at 11:31:36PM -0300, Thais Camacho wrote:
> Warning found by checkpatch.pl script
>
> Signed-off-by: Thais Camacho <thaiscamachoo@gmail.com>
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 4789d36ddfd3..2cb665e0228c 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const struct file_operations vmfile_fops;
> struct ashmem_area *asma = file->private_data;
> int ret = 0;
>
> --
> 2.20.1
Any specific reason why you did not test-build your change before
sending it to us? Please always do so, otherwise it causes lots of
problems, and makes maintainers grumpy :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-14 8:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 2:31 [PATCH] staging: android: ashmem: Declared file operation with const keyword Thais Camacho
2021-02-14 4:49 ` kernel test robot
2021-02-14 8:21 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-24 7:09 ratnesh-r1
2022-01-24 7:39 ` Greg Kroah-Hartman
2022-01-24 11:20 ` kernel test robot
2022-01-24 12:27 ` kernel test robot
2021-05-19 8:19 [PATCH] staging: android: ashmem: Declared file operation with 'const' keyword Hriday Hegde
2021-05-19 8:31 ` Greg Kroah-Hartman
2021-05-19 9:30 ` Hriday Hegde
2021-05-19 9:50 ` Greg Kroah-Hartman
2021-05-19 14:36 ` Hriday Hegde
2021-05-19 14:51 ` Fabio Aiuto
2021-05-19 15:54 ` Hriday Hegde
2021-05-19 14:55 ` Greg Kroah-Hartman
2021-05-19 15:56 ` Hriday Hegde
2020-12-28 5:13 [PATCH] staging: android: ashmem: Declared file operation with const keyword jovin555
2020-12-28 6:35 ` Greg Kroah-Hartman
2021-01-05 11:52 ` Dan Carpenter
2020-03-28 15:15 SandeshKenjanaAshok
2020-03-29 6:58 ` Greg Kroah-Hartman
2020-03-29 12:54 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCjdjdjcdXRUMhU/@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=thaiscamachoo@gmail.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox