From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26599C433DB for ; Mon, 15 Feb 2021 13:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFCCB64E29 for ; Mon, 15 Feb 2021 13:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230268AbhBON06 (ORCPT ); Mon, 15 Feb 2021 08:26:58 -0500 Received: from mga05.intel.com ([192.55.52.43]:22537 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230348AbhBON0R (ORCPT ); Mon, 15 Feb 2021 08:26:17 -0500 IronPort-SDR: cw0SpZJkWfXf4g7/3QC6uHGl92mHR9dAles+kJiIa7OQQIWSTcTncjwQCD5SeCXB1xDIp8qrvI PcS139KcfBDg== X-IronPort-AV: E=McAfee;i="6000,8403,9895"; a="267526103" X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="267526103" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 05:22:43 -0800 IronPort-SDR: Q92VLC8ChvVQp9ZTerRdIUQPLKHA+TrtS3HUJ9mgc6H5DzaPi59pZB7OXkoGrivf8EqbJjOAls AK0bhyIDQOVQ== X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="383365469" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 05:22:41 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lBdpm-005CRM-HF; Mon, 15 Feb 2021 15:22:38 +0200 Date: Mon, 15 Feb 2021 15:22:38 +0200 From: Andy Shevchenko To: Dejin Zheng Cc: daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, broonie@kernel.org, jan.kiszka@siemens.com, jarkko.nikula@linux.intel.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()' Message-ID: References: <20210214145746.602770-1-zhengdejin5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210214145746.602770-1-zhengdejin5@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 14, 2021 at 10:57:46PM +0800, Dejin Zheng wrote: > Call to 'pci_free_irq_vectors()' are missing both in the error handling > path of the probe function, and in the remove function. So add them. I'm wondering if you noticed that it's done by pcim_* API. Perhaps you can introduce pcim_alloc_irq_vectors() or so and do not add these calls at all? > Fixes: 64e02cb0bdfc7c ("spi: pca2xx-pci: Allow MSI") No, it doesn't fix anything. -- With Best Regards, Andy Shevchenko