* Re: [PATCH] drm/i915: Remove unused function pointer typedef long_pulse_detect_func [not found] <1613388619-3276-1-git-send-email-chen45464546@163.com> @ 2021-02-16 11:40 ` Ville Syrjälä 2021-02-16 15:39 ` [v2] drm/i915: Use function pointer typedef long_pulse_detect_func in intel_get_hpd_pins Chen Lin 0 siblings, 1 reply; 2+ messages in thread From: Ville Syrjälä @ 2021-02-16 11:40 UTC (permalink / raw) To: Chen Lin Cc: airlied, daniel, intel-gfx, linux-kernel, dri-devel, Chen Lin, rodrigo.vivi On Mon, Feb 15, 2021 at 07:30:19PM +0800, Chen Lin wrote: > From: Chen Lin <chen.lin5@zte.com.cn> > > Remove the 'long_pulse_detect_func' typedef as it is not used. > > Signed-off-by: Chen Lin <chen.lin5@zte.com.cn> > --- > drivers/gpu/drm/i915/i915_irq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 6cdb052..c294ac6 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -78,7 +78,6 @@ static inline void pmu_irq_stats(struct drm_i915_private *i915, > WRITE_ONCE(i915->pmu.irq_count, i915->pmu.irq_count + 1); > } > > -typedef bool (*long_pulse_detect_func)(enum hpd_pin pin, u32 val); > typedef u32 (*hotplug_enables_func)(struct drm_i915_private *i915, > enum hpd_pin pin); I thought we used in when passing it as an argument to intel_get_hpd_pins(), but looks like that's not the case. I guess we should unify this stuff by either removing both these typedefs and adjusting intel_hpd_hotplug_enables() accordingly, or we should use the typedef in intel_get_hpd_pins() as well. -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 2+ messages in thread
* [v2] drm/i915: Use function pointer typedef long_pulse_detect_func in intel_get_hpd_pins 2021-02-16 11:40 ` [PATCH] drm/i915: Remove unused function pointer typedef long_pulse_detect_func Ville Syrjälä @ 2021-02-16 15:39 ` Chen Lin 0 siblings, 0 replies; 2+ messages in thread From: Chen Lin @ 2021-02-16 15:39 UTC (permalink / raw) To: ville.syrjala Cc: airlied, daniel, intel-gfx, linux-kernel, dri-devel, rodrigo.vivi, chen.lin5 From: Chen Lin <chen.lin5@zte.com.cn> Use function pointer typedef long_pulse_detect_func in intel_get_hpd_pins. Signed-off-by: Chen Lin <chen.lin5@zte.com.cn> --- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 6cdb052..4339bad 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -1203,7 +1203,7 @@ static void intel_get_hpd_pins(struct drm_i915_private *dev_priv, u32 *pin_mask, u32 *long_mask, u32 hotplug_trigger, u32 dig_hotplug_reg, const u32 hpd[HPD_NUM_PINS], - bool long_pulse_detect(enum hpd_pin pin, u32 val)) + long_pulse_detect_func long_pulse_detect) { enum hpd_pin pin; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-16 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1613388619-3276-1-git-send-email-chen45464546@163.com>
2021-02-16 11:40 ` [PATCH] drm/i915: Remove unused function pointer typedef long_pulse_detect_func Ville Syrjälä
2021-02-16 15:39 ` [v2] drm/i915: Use function pointer typedef long_pulse_detect_func in intel_get_hpd_pins Chen Lin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox