From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6CEC433E0 for ; Tue, 16 Feb 2021 14:42:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97D6D64E07 for ; Tue, 16 Feb 2021 14:42:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbhBPOly (ORCPT ); Tue, 16 Feb 2021 09:41:54 -0500 Received: from mga06.intel.com ([134.134.136.31]:60032 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229916AbhBPOlL (ORCPT ); Tue, 16 Feb 2021 09:41:11 -0500 IronPort-SDR: jIas1xF4TaOMw+ssUkMtzicRfSWUDAzUO3b4FTlWVdjqE2uvNGLv88+rt1kqPeX96WU+LtIsPJ +vsmfDa+0+/A== X-IronPort-AV: E=McAfee;i="6000,8403,9896"; a="244377521" X-IronPort-AV: E=Sophos;i="5.81,183,1610438400"; d="scan'208";a="244377521" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2021 06:39:14 -0800 IronPort-SDR: zXTNp0diplCmlIc1HMcl9+3iipNwCOEwZUWnYn4bABY29FaA3CkgDNxoeIKWy3Mx9tjPvJn2Kj /KU7OBGzcpRA== X-IronPort-AV: E=Sophos;i="5.81,183,1610438400"; d="scan'208";a="493310383" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2021 06:39:11 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lC1VN-005U7J-4w; Tue, 16 Feb 2021 16:39:09 +0200 Date: Tue, 16 Feb 2021 16:39:09 +0200 From: Andy Shevchenko To: Dejin Zheng Cc: corbet@lwn.net, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, rric@kernel.org, bhelgaas@google.com, wsa@kernel.org, linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, kw@linux.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] i2c: designware: Use the correct name of device-managed function Message-ID: References: <20210216141810.747678-1-zhengdejin5@gmail.com> <20210216141810.747678-4-zhengdejin5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210216141810.747678-4-zhengdejin5@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2021 at 10:18:09PM +0800, Dejin Zheng wrote: > Use the new function pcim_alloc_irq_vectors() to allocate IRQ vectors, > the pcim_alloc_irq_vectors() function, an explicit device-managed version > of pci_alloc_irq_vectors(). If pcim_enable_device() has been called > before, then pci_alloc_irq_vectors() is actually a device-managed > function. It is used here as a device-managed function, So replace it > with pcim_alloc_irq_vectors(). ... > - r = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES); > + r = pcim_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES); > if (r < 0) > return r; It's good, but now why do we have pci_free_irq_vectors() in the same file? -- With Best Regards, Andy Shevchenko