From: Rustam Kovhaev <rkovhaev@gmail.com>
To: Anton Altaparmakov <anton@tuxera.com>
Cc: "linux-ntfs-dev@lists.sourceforge.net"
<linux-ntfs-dev@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] ntfs: move check for valid resident attribute offset and length
Date: Tue, 16 Feb 2021 08:24:20 -0800 [thread overview]
Message-ID: <YCvxtL5WYeO3ofKW@nuc10> (raw)
In-Reply-To: <2727F0B7-4992-4B24-963F-CC3C4D94CFD2@tuxera.com>
On Tue, Feb 16, 2021 at 02:40:37AM +0000, Anton Altaparmakov wrote:
> Hi Rustam,
>
> Thank you for the patch but it is not quite correct:
>
> 1) The first delta: yes that is a good idea to add this check but the error message is incorrect. It should say "Corrupt standard information attribute in inode." instead.
>
> 2) The second delta: The check of the attribute list attribute needs to remain, i.e. your second delta needs to be deleted.
>
> Please could you address both of the above comments and then resend? Please then also add: "Acked-by: Anton Altaparmakov <anton@tuxera.com>" to the patch.
>
> Thanks a lot in advance!
>
> Best regards,
>
> Anton
>
hi Anton, thank you for the review! I'll resend the patch!
prev parent reply other threads:[~2021-02-16 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 22:12 [PATCH] ntfs: move check for valid resident attribute offset and length Rustam Kovhaev
2021-02-16 2:40 ` Anton Altaparmakov
2021-02-16 16:24 ` Rustam Kovhaev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCvxtL5WYeO3ofKW@nuc10 \
--to=rkovhaev@gmail.com \
--cc=anton@tuxera.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox