From: Greg KH <gregkh@linuxfoundation.org>
To: Min Li <min.li.xe@renesas.com>
Cc: "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
"dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support
Date: Wed, 17 Feb 2021 08:11:49 +0100 [thread overview]
Message-ID: <YCzBtRaVJcoJ1DzA@kroah.com> (raw)
In-Reply-To: <OSBPR01MB477356F3FBDCB752286C65D0BA879@OSBPR01MB4773.jpnprd01.prod.outlook.com>
On Tue, Feb 16, 2021 at 07:50:49PM +0000, Min Li wrote:
> >
> > Yes, that line.
> >
> > The documentation should tell you how to do that, as per my patch bot:
> >
> > - This looks like a new version of a previously submitted patch, but you
> > did not list below the --- line any changes from the previous version.
> > Please read the section entitled "The canonical patch format" in the
> > kernel file, Documentation/SubmittingPatches for what needs to be done
> > here to properly describe this.
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg
>
> I read documentation. Am I supposed to add the "---" marker line manually by myself when doing "git commit --amend"? git commit will
> always add a "---" marker line before the actual change like below
>
> Signed-off-by: Min Li <min.li.xe@renesas.com>
> ---
> Changes since v1:
> -Provide more background for purpose of the change.
> -Provide compat_ioctl support
> -Fix ioctl cmd definition
> ---
> drivers/misc/Kconfig | 13 ++
> drivers/misc/Makefile | 3 +
You add the text after you have created the patch with 'git
format-patch' by editing the text file before sending it off to us. You
don't add it to the changelog comment itself.
hope this helps,
greg k-h
prev parent reply other threads:[~2021-02-17 7:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 1:16 [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support min.li.xe
2021-02-12 7:39 ` Greg KH
2021-02-12 15:39 ` Min Li
2021-02-12 15:48 ` Greg KH
2021-02-12 16:02 ` Min Li
2021-02-12 16:22 ` Greg KH
2021-02-12 7:40 ` Greg KH
2021-02-12 15:44 ` Min Li
2021-02-12 15:55 ` Greg KH
2021-02-12 16:04 ` Min Li
2021-02-12 19:06 ` Min Li
2021-02-13 8:28 ` Greg KH
2021-02-16 19:50 ` Min Li
2021-02-17 7:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCzBtRaVJcoJ1DzA@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox