* [PATCH] char: lp: remove redundant space
@ 2021-03-03 11:39 maqiang
2021-03-03 13:55 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: maqiang @ 2021-03-03 11:39 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, maqiang
These two lines of code don't meet the kernel coding style,
so remove the redundant space.
Signed-off-by: maqiang <maqianga@uniontech.com>
---
drivers/char/lp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/lp.c b/drivers/char/lp.c
index 862c2fd933c7..0e22e3b0a04e 100644
--- a/drivers/char/lp.c
+++ b/drivers/char/lp.c
@@ -546,7 +546,7 @@ static int lp_open(struct inode *inode, struct file *file)
}
/* Determine if the peripheral supports ECP mode */
lp_claim_parport_or_block(&lp_table[minor]);
- if ( (lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
+ if ((lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
!parport_negotiate(lp_table[minor].dev->port,
IEEE1284_MODE_ECP)) {
printk(KERN_INFO "lp%d: ECP mode\n", minor);
@@ -590,7 +590,7 @@ static int lp_do_ioctl(unsigned int minor, unsigned int cmd,
return -ENODEV;
if ((LP_F(minor) & LP_EXIST) == 0)
return -ENODEV;
- switch ( cmd ) {
+ switch (cmd) {
case LPTIME:
if (arg > UINT_MAX / HZ)
return -EINVAL;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] char: lp: remove redundant space
@ 2021-03-04 7:21 maqiang
2021-03-04 7:34 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: maqiang @ 2021-03-04 7:21 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, maqiang
These two lines of code don't meet the kernel coding style,
so remove the redundant space.
Signed-off-by: Qiang Ma <maqianga@uniontech.com>
Signed-off-by: maqiang <maqianga@uniontech.com>
---
drivers/char/lp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/lp.c b/drivers/char/lp.c
index 862c2fd933c7..0e22e3b0a04e 100644
--- a/drivers/char/lp.c
+++ b/drivers/char/lp.c
@@ -546,7 +546,7 @@ static int lp_open(struct inode *inode, struct file *file)
}
/* Determine if the peripheral supports ECP mode */
lp_claim_parport_or_block(&lp_table[minor]);
- if ( (lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
+ if ((lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
!parport_negotiate(lp_table[minor].dev->port,
IEEE1284_MODE_ECP)) {
printk(KERN_INFO "lp%d: ECP mode\n", minor);
@@ -590,7 +590,7 @@ static int lp_do_ioctl(unsigned int minor, unsigned int cmd,
return -ENODEV;
if ((LP_F(minor) & LP_EXIST) == 0)
return -ENODEV;
- switch ( cmd ) {
+ switch (cmd) {
case LPTIME:
if (arg > UINT_MAX / HZ)
return -EINVAL;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] char: lp: remove redundant space
2021-03-04 7:21 maqiang
@ 2021-03-04 7:34 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-03-04 7:34 UTC (permalink / raw)
To: maqiang; +Cc: arnd, linux-kernel
On Thu, Mar 04, 2021 at 03:21:47PM +0800, maqiang wrote:
> These two lines of code don't meet the kernel coding style,
> so remove the redundant space.
>
> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
> Signed-off-by: maqiang <maqianga@uniontech.com>
Why do you have 2 signed-off-by lines with the same email address, but
different names?
If you want to start out in kernel development for coding style fixes, I
recommend doing so in drivers/staging/ as patches there for things like
this are more welcome than other parts of the kernel.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] char: lp: remove redundant space
@ 2021-03-04 8:17 Qiang Ma
2021-03-04 8:37 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Qiang Ma @ 2021-03-04 8:17 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, Qiang Ma
These two lines of code don't meet the kernel coding style,
so remove the redundant space.
Signed-off-by: Qiang Ma <maqianga@uniontech.com>
---
drivers/char/lp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/lp.c b/drivers/char/lp.c
index 862c2fd933c7..0e22e3b0a04e 100644
--- a/drivers/char/lp.c
+++ b/drivers/char/lp.c
@@ -546,7 +546,7 @@ static int lp_open(struct inode *inode, struct file *file)
}
/* Determine if the peripheral supports ECP mode */
lp_claim_parport_or_block(&lp_table[minor]);
- if ( (lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
+ if ((lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
!parport_negotiate(lp_table[minor].dev->port,
IEEE1284_MODE_ECP)) {
printk(KERN_INFO "lp%d: ECP mode\n", minor);
@@ -590,7 +590,7 @@ static int lp_do_ioctl(unsigned int minor, unsigned int cmd,
return -ENODEV;
if ((LP_F(minor) & LP_EXIST) == 0)
return -ENODEV;
- switch ( cmd ) {
+ switch (cmd) {
case LPTIME:
if (arg > UINT_MAX / HZ)
return -EINVAL;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] char: lp: remove redundant space
2021-03-04 8:17 Qiang Ma
@ 2021-03-04 8:37 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-03-04 8:37 UTC (permalink / raw)
To: Qiang Ma; +Cc: arnd, linux-kernel
On Thu, Mar 04, 2021 at 04:17:52PM +0800, Qiang Ma wrote:
> These two lines of code don't meet the kernel coding style,
> so remove the redundant space.
>
> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
> ---
> drivers/char/lp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/lp.c b/drivers/char/lp.c
> index 862c2fd933c7..0e22e3b0a04e 100644
> --- a/drivers/char/lp.c
> +++ b/drivers/char/lp.c
> @@ -546,7 +546,7 @@ static int lp_open(struct inode *inode, struct file *file)
> }
> /* Determine if the peripheral supports ECP mode */
> lp_claim_parport_or_block(&lp_table[minor]);
> - if ( (lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
> + if ((lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
> !parport_negotiate(lp_table[minor].dev->port,
> IEEE1284_MODE_ECP)) {
> printk(KERN_INFO "lp%d: ECP mode\n", minor);
> @@ -590,7 +590,7 @@ static int lp_do_ioctl(unsigned int minor, unsigned int cmd,
> return -ENODEV;
> if ((LP_F(minor) & LP_EXIST) == 0)
> return -ENODEV;
> - switch ( cmd ) {
> + switch (cmd) {
> case LPTIME:
> if (arg > UINT_MAX / HZ)
> return -EINVAL;
> --
> 2.20.1
>
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-04 8:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-03 11:39 [PATCH] char: lp: remove redundant space maqiang
2021-03-03 13:55 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-03-04 7:21 maqiang
2021-03-04 7:34 ` Greg KH
2021-03-04 8:17 Qiang Ma
2021-03-04 8:37 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox