From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C985C433E0 for ; Mon, 1 Mar 2021 15:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32E10601FE for ; Mon, 1 Mar 2021 15:14:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237083AbhCAPOQ (ORCPT ); Mon, 1 Mar 2021 10:14:16 -0500 Received: from mga12.intel.com ([192.55.52.136]:61329 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236976AbhCAPM0 (ORCPT ); Mon, 1 Mar 2021 10:12:26 -0500 IronPort-SDR: 5jHpC6rkxwmGn0oAjVmqZm5jKjfDKiCRukWGvwdX4CHDjXUVBmFmfsC8iH98BrpoZ/hkSrpPrh 6SzWs9Vj4G8g== X-IronPort-AV: E=McAfee;i="6000,8403,9910"; a="165725489" X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="165725489" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 07:10:39 -0800 IronPort-SDR: ixy11YE67IpJBPDk+MiFCAFmaRxOKAb13L234gqYwXns6Az3YIhZx/gtgP8ReYzcaOrf1rvn+F XgA9WaSaltww== X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="505098702" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 07:10:37 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lGkBv-009ALW-5R; Mon, 01 Mar 2021 17:10:35 +0200 Date: Mon, 1 Mar 2021 17:10:35 +0200 From: Andy Shevchenko To: Heikki Krogerus Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] software node: Fix node registration Message-ID: References: <20210301143012.55118-1-heikki.krogerus@linux.intel.com> <20210301143012.55118-2-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301143012.55118-2-heikki.krogerus@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 01, 2021 at 05:30:11PM +0300, Heikki Krogerus wrote: > Software node can not be registered before its parent. Reviewed-by: Andy Shevchenko Tested-by: Andy Shevchenko (On Intel Galileo Gen 2 with some custom patches to convert gpio-dwapb et al. to use swnodes. Those patches a subject to further submission.) Thanks! > Fixes: 80488a6b1d3c ("software node: Add support for static node descriptors") > Cc: stable@vger.kernel.org > Signed-off-by: Heikki Krogerus > --- > drivers/base/swnode.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index 37179a8b1ceba..74db8c971db74 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -938,6 +938,9 @@ int software_node_register(const struct software_node *node) > if (software_node_to_swnode(node)) > return -EEXIST; > > + if (node->parent && !parent) > + return -EINVAL; > + > return PTR_ERR_OR_ZERO(swnode_register(node, parent, 0)); > } > EXPORT_SYMBOL_GPL(software_node_register); > -- > 2.30.1 > -- With Best Regards, Andy Shevchenko