From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C843C433E0 for ; Mon, 1 Mar 2021 15:49:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAC3964DDE for ; Mon, 1 Mar 2021 15:49:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237394AbhCAPtk (ORCPT ); Mon, 1 Mar 2021 10:49:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:49144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236819AbhCAPtf (ORCPT ); Mon, 1 Mar 2021 10:49:35 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6DE0164D5D; Mon, 1 Mar 2021 15:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614613731; bh=+Bxis+ONYci93egO14cf82r4FRYtcyZFGUGkTd/7a0g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1QlyahBJyzsO9LGwNjoXnhqOSu3UMh/jh/e1koJSq0tAKQ6dS6cWG46cf1F7eBSeM Hz1g5gysEEfzP6wGrAcRNYVFS6MPaPh14IU1yRG6IQyIqPZfHmCt9swGo6jaCgyuX3 OyfWOZMz3s42VyMW23uysBwsWh/qeGqzTvyArUpw= Date: Mon, 1 Mar 2021 16:48:48 +0100 From: Greg Kroah-Hartman To: Dmitry Baryshkov Cc: Arnd Bergmann , open list , Srinivas Kandagatla , Jonathan Marek , stable@vger.kernel.org Subject: Re: [PATCH v2] misc: fastrpc: restrict user apps from sending kernel RPC messages Message-ID: References: <20210212192658.3476137-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 01, 2021 at 06:34:10PM +0300, Dmitry Baryshkov wrote: > On Sat, 13 Feb 2021 at 11:25, Greg Kroah-Hartman > wrote: > > > > On Fri, Feb 12, 2021 at 10:26:58PM +0300, Dmitry Baryshkov wrote: > > > Verify that user applications are not using the kernel RPC message > > > handle to restrict them from directly attaching to guest OS on the > > > remote subsystem. This is a port of CVE-2019-2308 fix. > > > > A port of the fix of what to what? > > I'm sorry for the confusion. It is a port of the original > Qualcomm/CodeAurora fix to the upstream driver. > > See https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?id=cc2e11eeb988964af72309f71b0fb21c11ed6ca9, So this is a fix from 2019 that you never submitted upstream causing all of these kernels to be vulnerable? Shouldn't the porting process go the other way, upstream first and then backport? That ensures we don't end up with 2 years old bugs like this :( Ugh. What's going to change in the development process of this code to prevent this from happening again? thanks, greg k-h