From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf tools: Fix documentation of verbose options
Date: Tue, 2 Mar 2021 09:36:38 -0300 [thread overview]
Message-ID: <YD4xVsqs6yqaqB+Z@kernel.org> (raw)
In-Reply-To: <20210226183145.1878782-1-irogers@google.com>
Em Fri, Feb 26, 2021 at 10:31:44AM -0800, Ian Rogers escreveu:
> Option doesn't take a value, make sure the man pages agree. For example:
>
> $ perf evlist --verbose=1
> Error: option `verbose' takes no value
Thanks, applied.
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/Documentation/perf-evlist.txt | 2 +-
> tools/perf/Documentation/perf-ftrace.txt | 4 ++--
> tools/perf/Documentation/perf-kallsyms.txt | 2 +-
> tools/perf/Documentation/perf-trace.txt | 4 ++--
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-evlist.txt b/tools/perf/Documentation/perf-evlist.txt
> index c0a66400a960..9af8b8dfb7b6 100644
> --- a/tools/perf/Documentation/perf-evlist.txt
> +++ b/tools/perf/Documentation/perf-evlist.txt
> @@ -29,7 +29,7 @@ OPTIONS
> Show just the sample frequency used for each event.
>
> -v::
> ---verbose=::
> +--verbose::
> Show all fields.
>
> -g::
> diff --git a/tools/perf/Documentation/perf-ftrace.txt b/tools/perf/Documentation/perf-ftrace.txt
> index 1e91121bac0f..6e82b7cc0bf0 100644
> --- a/tools/perf/Documentation/perf-ftrace.txt
> +++ b/tools/perf/Documentation/perf-ftrace.txt
> @@ -28,8 +28,8 @@ OPTIONS
> specified: function_graph or function.
>
> -v::
> ---verbose=::
> - Verbosity level.
> +--verbose::
> + Increase the verbosity level.
>
> -F::
> --funcs::
> diff --git a/tools/perf/Documentation/perf-kallsyms.txt b/tools/perf/Documentation/perf-kallsyms.txt
> index f3c620951f6e..c97527df8ecd 100644
> --- a/tools/perf/Documentation/perf-kallsyms.txt
> +++ b/tools/perf/Documentation/perf-kallsyms.txt
> @@ -20,5 +20,5 @@ modules).
> OPTIONS
> -------
> -v::
> ---verbose=::
> +--verbose::
> Increase verbosity level, showing details about symbol table loading, etc.
> diff --git a/tools/perf/Documentation/perf-trace.txt b/tools/perf/Documentation/perf-trace.txt
> index abc9b5d83312..f0da8cf63e9a 100644
> --- a/tools/perf/Documentation/perf-trace.txt
> +++ b/tools/perf/Documentation/perf-trace.txt
> @@ -97,8 +97,8 @@ filter out the startup phase of the program, which is often very different.
> Filter out events for these pids and for 'trace' itself (comma separated list).
>
> -v::
> ---verbose=::
> - Verbosity level.
> +--verbose::
> + Increase the verbosity level.
>
> --no-inherit::
> Child tasks do not inherit counters.
> --
> 2.30.1.766.gb4fecdf3b7-goog
>
--
- Arnaldo
prev parent reply other threads:[~2021-03-02 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 18:31 [PATCH] perf tools: Fix documentation of verbose options Ian Rogers
2021-03-02 12:36 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD4xVsqs6yqaqB+Z@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox