From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BEB8C433E0 for ; Tue, 2 Mar 2021 20:21:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 246DD64F0D for ; Tue, 2 Mar 2021 20:21:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1836571AbhCBUUb (ORCPT ); Tue, 2 Mar 2021 15:20:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1446568AbhCBRaF (ORCPT ); Tue, 2 Mar 2021 12:30:05 -0500 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D0E6C06121E for ; Tue, 2 Mar 2021 08:53:55 -0800 (PST) Received: by mail-ot1-x32d.google.com with SMTP id f33so20585660otf.11 for ; Tue, 02 Mar 2021 08:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F7NOrHOLrccy/SQYMTkigwceK69ASy8V14Aa+3j99bQ=; b=HaGDtAiGBkHeEySoib/HgAjObyaLvIEO+kyFZlxNnfM6m0FBX22R0B9bn4t0of4Xpu M6akWjJXtNhTuq3H3Jxtubj2nkG+d2BoYJL1N7Nzd9pZxj2r3VDBXdRqXf9YTSJ0LFmm amxrP2tLQH7iFCvGPSwuXS5PGpc2sug7Tb/wtelrn3b4WND32n4MCYhFmbwQUg3tTmeJ 3eWCIhXJ19+7kSVVuMrU0zZVeruzc/XRz7OJFHNj2bPByAmoa6RhPMZjCJ2t385vbk01 G9oq1HHzIW+qu853DujxiVTv0/dY/2bB1lhRU/d9Dfjbj3lUerqLE57aJMBTXuV9LUTW AScw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F7NOrHOLrccy/SQYMTkigwceK69ASy8V14Aa+3j99bQ=; b=luNoMQHqusuC0wos15+YlxtI/J8wLjpoBQ9/ET0dYUmsdHto2rym5PIQL3Dt0w9PC2 lzw8Q8BsvY/qktfgyhWmdhxKV2Nr2cn0u+ZW0feLOcfxka922MGMz1ws2g9CywG2E2Uw LIYt2CxPM+BVyVvLRoSHU9p6NWQkd3DZoElJrUtaS1qt1qX4k5GUna1ZzKiIB4+HmNW+ wCxZ2aataV4RtKSZB5jThWf1200mneJLxVO01BNzr0VcDXVzf+ylj68o+xt0tULcrWcx 79bxmwu360yyZbLIW7O8pbKHRhQXtZ25p0FIKaEr2zSsdGNS8xSZe62BKCzWgitGTcey oYzg== X-Gm-Message-State: AOAM530Z3TKGx2cyViHvvmh6myQSkfqW46m0aaBMeEddMKjoSPOiSSyo brp2eAB4w51SeI4YDUT7TBIs9w== X-Google-Smtp-Source: ABdhPJwanh1Ukx8/FCiG0K/XEaIcouQScmaD5Vtqgr/fJqX/Fp9weERJKzABkE6PIyLpg39iwlbRag== X-Received: by 2002:a05:6830:1682:: with SMTP id k2mr18829829otr.154.1614704034746; Tue, 02 Mar 2021 08:53:54 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id g3sm4032647ooi.28.2021.03.02.08.53.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 08:53:54 -0800 (PST) Date: Tue, 2 Mar 2021 10:53:52 -0600 From: Bjorn Andersson To: Linus Walleij Cc: Dan Carpenter , Srinivas Kandagatla , kbuild@lists.01.org, kbuild test robot , kbuild-all@lists.01.org, "linux-kernel@vger.kernel.org" Subject: Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'. Message-ID: References: <20210227092152.GC2087@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 02 Mar 09:47 CST 2021, Linus Walleij wrote: > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter wrote: > > > New smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'. > > > > Old smatch warnings: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: uninitialized symbol 'pullup'. > > I don't think these are real problems, but maybe there is some way to explicitly > express that so that smatch knows as well? > Perhaps I'm reading it wrong, but wouldn't a state that doesn't specify drive-strength or bias cause these properties to be written out as some undefined/uninitialized value? (I.e. isn't the report correct?) Regards, Bjorn