From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68DF3C433DB for ; Tue, 2 Mar 2021 22:08:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3233664F35 for ; Tue, 2 Mar 2021 22:08:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1837816AbhCBV7R (ORCPT ); Tue, 2 Mar 2021 16:59:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1581644AbhCBTBZ (ORCPT ); Tue, 2 Mar 2021 14:01:25 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58A40C0617A9 for ; Tue, 2 Mar 2021 10:56:26 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id g20so12574246plo.2 for ; Tue, 02 Mar 2021 10:56:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UakjRFV7I3zgiMcVHz9PtvL5bu+2z3t7UmhBb2UlaRo=; b=KOCX7C/n+Giax9CXgQLNaBQzEb8gAwWJ0mMJs148tKVI2Z1/pG4LQoGmsvTtEBGKvr yDrvvnI9NjgIE2Mv8gfq2rwz5L7zJpMp4LMG7WCMWuDstbzuIxbz/ZqELiyJVHNMF5w3 fFTXxk9P6pfeVcjBlbH1WOMAbxAKOAgjnSgPyfyA7qnRRVPShQR46EsMsYM1ORHrSHfB xVuSCmvU5xZr2Y34isIfUWccfDO28BXczsobuwbvJGe6pgjPiTShcveau+lWSklRZ3rt Ef4uVEn7/4yn76fOPbbCsrLsDfFYpL1lNd9thhIq3UKuwfR0/MNk0hE2xP5263Otab7U Mrzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UakjRFV7I3zgiMcVHz9PtvL5bu+2z3t7UmhBb2UlaRo=; b=aSEaHXdx4oxMT0gU8PpX3O8HZiQlwxLCYlyKrWjq1VzfQ3n7Y8VaK0GFHZjrW9gx7e gzFCp4ExrM/zq/zQLXQQ0RnnACJIZLqxZZ+4phb6aSZGGO/sW9u3YVYj9w3s5EoDBSMt VCtSRmDfmLHYKSPUY+VLDn17nHvch7FCXYsqvhxYMSKPBKByynqtibCM7ZMKFEnM3OJi G/kEZ4xqszTBOqIrNJLVAsqPZc1VNyuMiD8IQGpB/qPCDlz/erpCPk8sBm7qEUQwdwJm Cin31mLgePAJPVyKUO2QDQqFD7+HOx/NEpAzS0mgqRPlZGoLv/uKxfUYuXlhpjmTlDCF Uvxg== X-Gm-Message-State: AOAM531X8qqmOIql4NRjZLAYQZX1XyLVFCsh0k0hGhNDdcjpfo7FzFfS wUiKsbGmZ7zqFBDjgeE+6RTtRQ== X-Google-Smtp-Source: ABdhPJz/3iWxNd/0QEjau5XG3vSh9x0ae3R/TPebaeYLJJ/xMuUMzOpoGvO+Wy+HJKTG0YdOE1v9gw== X-Received: by 2002:a17:90a:cd06:: with SMTP id d6mr5755840pju.138.1614711385768; Tue, 02 Mar 2021 10:56:25 -0800 (PST) Received: from google.com ([2620:15c:f:10:805d:6324:3372:6183]) by smtp.gmail.com with ESMTPSA id z11sm20733810pgc.6.2021.03.02.10.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 10:56:25 -0800 (PST) Date: Tue, 2 Mar 2021 10:56:18 -0800 From: Sean Christopherson To: Paolo Bonzini Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/11] KVM: VMX: Clean up Hyper-V PV TLB flush Message-ID: References: <20201027212346.23409-1-sean.j.christopherson@intel.com> <7ed340f1-f6f7-4682-65be-6bc02f25d612@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ed340f1-f6f7-4682-65be-6bc02f25d612@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2021, Paolo Bonzini wrote: > On 27/10/20 22:23, Sean Christopherson wrote: > > Clean up KVM's PV TLB flushing when running with EPT on Hyper-V, i.e. as > > a nested VMM. No real goal in mind other than the sole patch in v1, which > > is a minor change to avoid a future mixup when TDX also wants to define > > .remote_flush_tlb. Everything else is opportunistic clean up. > > > > Patch 1 legitimately tested on VMX (no SVM), everything else effectively > > build tested only. > > > > v3: > > - Add a patch to pass the root_hpa instead of pgd to vmx_load_mmu_pgd() > > and retrieve the active PCID only when necessary. [Vitaly] > > - Selectively collects reviews (skipped a few due to changes). [Vitaly] > > - Explicitly invalidate hv_tlb_eptp instead of leaving it valid when > > the mismatch tracker "knows" it's invalid. [Vitaly] > > - Change the last patch to use "hv_root_ept" instead of "hv_tlb_pgd" > > to better reflect what is actually being tracked. > > > > v2: Rewrite everything. > > Sean Christopherson (11): > > KVM: x86: Get active PCID only when writing a CR3 value > > KVM: VMX: Track common EPTP for Hyper-V's paravirt TLB flush > > KVM: VMX: Stash kvm_vmx in a local variable for Hyper-V paravirt TLB > > flush > > KVM: VMX: Fold Hyper-V EPTP checking into it's only caller > > KVM: VMX: Do Hyper-V TLB flush iff vCPU's EPTP hasn't been flushed > > KVM: VMX: Invalidate hv_tlb_eptp to denote an EPTP mismatch > > KVM: VMX: Don't invalidate hv_tlb_eptp if the new EPTP matches > > KVM: VMX: Explicitly check for hv_remote_flush_tlb when loading pgd > > KVM: VMX: Define Hyper-V paravirt TLB flush fields iff Hyper-V is > > enabled > > KVM: VMX: Skip additional Hyper-V TLB EPTP flushes if one fails > > KVM: VMX: Track root HPA instead of EPTP for paravirt Hyper-V TLB > > flush > > > > arch/x86/include/asm/kvm_host.h | 4 +- > > arch/x86/kvm/mmu.h | 2 +- > > arch/x86/kvm/svm/svm.c | 4 +- > > arch/x86/kvm/vmx/vmx.c | 134 ++++++++++++++++++-------------- > > arch/x86/kvm/vmx/vmx.h | 19 ++--- > > 5 files changed, 87 insertions(+), 76 deletions(-) > > > > Queued, thanks. Looks like this got shadow-banned, I'll send v4.