Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

Jason Gunthorpe
2021-03-02T01:39:50Z

On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote:
> commit 6e61907779ba99af785f5b2397a84077c289888a
> Author: Julian Braha <julianbraha@gmail.com>
> Date: Fri Feb 19 18:20:57 2021 -0500
>
> drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO
>
> When RDMA_RXE is enabled and CRYPTO is disabled,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_CRC32
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y]
>
> This is because RDMA_RXE selects CRYPTO_CRC32,
> without depending on or selecting CRYPTO, despite that config option
> being subordinate to CRYPTO.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>

Your patch was horribly mangled in patchworks, I fixed it, but you
need to send patches properly if you intend to send more to the kernel

Applied to for-rc

Thanks,
Jason