From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B578C433DB for ; Wed, 24 Feb 2021 07:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BD6764ECF for ; Wed, 24 Feb 2021 07:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234385AbhBXHbb (ORCPT ); Wed, 24 Feb 2021 02:31:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:55392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232343AbhBXHbT (ORCPT ); Wed, 24 Feb 2021 02:31:19 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E69E64ECB; Wed, 24 Feb 2021 07:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614151838; bh=6KWcfVE7ehtOI43lndv+QRd+lKd96Y/+ShOkch0BvBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FZHdrLqNH9uYP4vwZ06tHXixoDEsOIIeNQG4EdVvL7nVAYr01/NALZADmr5WLBX66 l/CUvVBaVrpsn08NRUIVUuwwsveAAi8h5jwjMVegQNhbR8i5Q+R8cJiwkJuFQJXMVP 7HC8e6PCqBmVISCDhgKqnWm+eaXrYAY4YLFxEu1w= Date: Wed, 24 Feb 2021 08:30:35 +0100 From: Greg Kroah-Hartman To: chakravarthi Kulkarni Cc: Ian Abbott , H Hartley Sweeten , Ethan Edwards , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: comedi: Fixed side effects from macro definition. Message-ID: References: <20210217142008.29699-1-chakravarthikulkarni2021@gmail.com> <3c1ddf91-da6c-5620-61e7-1ec453b2aa93@mev.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Feb 24, 2021 at 12:47:26PM +0530, chakravarthi Kulkarni wrote: > Hi, > > I tested it will unit test cases it looks fine. > int x = 10; > NI_USUAL_PFI_SELECT(x++) > > will not have side effects as it is taken care using local variable in > macro. You ignored what Ian said about why this change was not ok :( It's long deleted from my review queue, sorry. greg k-h