From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Ian Rogers <irogers@google.com>
Subject: Re: [PATCH v2 1/2] libperf: Add perf_evlist__reset_id_hash()
Date: Thu, 25 Feb 2021 17:12:37 +0100 [thread overview]
Message-ID: <YDfMdQCfO6ivN71v@krava> (raw)
In-Reply-To: <20210225035148.778569-1-namhyung@kernel.org>
On Thu, Feb 25, 2021 at 12:51:47PM +0900, Namhyung Kim wrote:
> Add the perf_evlist__reset_id_hash() function as an internal function
> so that it can be called by perf to reset the hash table. This is
> necessary for perf stat to run the workload multiple times.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
for the patchset
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
> ---
> tools/lib/perf/evlist.c | 13 +++++++++----
> tools/lib/perf/include/internal/evlist.h | 2 ++
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/tools/lib/perf/evlist.c b/tools/lib/perf/evlist.c
> index 17465d454a0e..a0aaf385cbb5 100644
> --- a/tools/lib/perf/evlist.c
> +++ b/tools/lib/perf/evlist.c
> @@ -26,13 +26,10 @@
>
> void perf_evlist__init(struct perf_evlist *evlist)
> {
> - int i;
> -
> - for (i = 0; i < PERF_EVLIST__HLIST_SIZE; ++i)
> - INIT_HLIST_HEAD(&evlist->heads[i]);
> INIT_LIST_HEAD(&evlist->entries);
> evlist->nr_entries = 0;
> fdarray__init(&evlist->pollfd, 64);
> + perf_evlist__reset_id_hash(evlist);
> }
>
> static void __perf_evlist__propagate_maps(struct perf_evlist *evlist,
> @@ -237,6 +234,14 @@ static void perf_evlist__id_hash(struct perf_evlist *evlist,
> hlist_add_head(&sid->node, &evlist->heads[hash]);
> }
>
> +void perf_evlist__reset_id_hash(struct perf_evlist *evlist)
> +{
> + int i;
> +
> + for (i = 0; i < PERF_EVLIST__HLIST_SIZE; ++i)
> + INIT_HLIST_HEAD(&evlist->heads[i]);
> +}
> +
> void perf_evlist__id_add(struct perf_evlist *evlist,
> struct perf_evsel *evsel,
> int cpu, int thread, u64 id)
> diff --git a/tools/lib/perf/include/internal/evlist.h b/tools/lib/perf/include/internal/evlist.h
> index 2d0fa02b036f..212c29063ad4 100644
> --- a/tools/lib/perf/include/internal/evlist.h
> +++ b/tools/lib/perf/include/internal/evlist.h
> @@ -124,4 +124,6 @@ int perf_evlist__id_add_fd(struct perf_evlist *evlist,
> struct perf_evsel *evsel,
> int cpu, int thread, int fd);
>
> +void perf_evlist__reset_id_hash(struct perf_evlist *evlist);
> +
> #endif /* __LIBPERF_INTERNAL_EVLIST_H */
> --
> 2.30.0.617.g56c4b15f3c-goog
>
next prev parent reply other threads:[~2021-02-25 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 3:51 [PATCH v2 1/2] libperf: Add perf_evlist__reset_id_hash() Namhyung Kim
2021-02-25 3:51 ` [PATCH v2 2/2] perf stat: Fix use-after-free when -r option is used Namhyung Kim
2021-02-25 16:12 ` Jiri Olsa [this message]
2021-03-03 15:51 ` [PATCH v2 1/2] libperf: Add perf_evlist__reset_id_hash() Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDfMdQCfO6ivN71v@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox