Re: [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy

Doug Anderson
2021-03-15T17:42:00Z

Hi,

On Sat, Mar 13, 2021 at 4:28 PM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> > usb_1_qmpphy: phy-wrapper@88e9000 {
> > - compatible = "qcom,sc7180-qmp-usb3-phy";
> > + compatible = "qcom,sc7180-qmp-usb3-dp-phy";
> > reg = <0 0x088e9000 0 0x18c>,
> > - <0 0x088e8000 0 0x38>;
> > - reg-names = "reg-base", "dp_com";
> > + <0 0x088e8000 0 0x38>,
>
> Technically this should be 0x3c. Offset 0x38 is USB3_DP_COM_REVISION_ID3
> (not used by the current driver though).
>
> > + <0 0x088ea000 0 0x40>;
>
> I think 0x40 is not enough here.
> This is a serdes region and qmp_v3_dp_serdes_tbl contains registers
> 0x148 and 0x154.

OK!

https://lore.kernel.org/r/20210315103836.1.I9a97120319d43b42353aeac4d348624d60687df7@changeid

-Doug