Re: [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown

Doug Anderson
2021-02-25T22:59:00Z

Hi,

On Thu, Feb 25, 2021 at 2:55 PM Konrad Dybcio
<konrad.dybcio@somainline.org> wrote:
>
> Hi,
>
>
> >
> > +&pri_mi2s_active {
> > + pinconf {
> > + pins = "gpio53", "gpio54", "gpio55", "gpio56";
> > + drive-strength = <2>;
> > + bias-pull-down;
> > + };
> > +};
> > +
>
> You can omit pinconf{}, so the outcome would be:
> &pri_mi2s_active {
>
> pins = ...
>
> ...
>
> };
>
>
> This makes the DTs ever so shorter and is the style that's currently used for new submissions.
>
> Same goes for the nodes that are being referenced.

Yes, I agree. That definitely makes sense going forward, but I think
it'll just add to the confusion to switch a dts for a given SoC
mid-stride. ...or, if we do switch the style it should be done in a
separate (no-op) patch series. This series is already giant enough...

-Doug