From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2434C433E6 for ; Fri, 26 Feb 2021 02:14:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72EB864F1F for ; Fri, 26 Feb 2021 02:14:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230104AbhBZCOP (ORCPT ); Thu, 25 Feb 2021 21:14:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbhBZCOL (ORCPT ); Thu, 25 Feb 2021 21:14:11 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4161BC061786 for ; Thu, 25 Feb 2021 18:13:31 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id t9so5096171pjl.5 for ; Thu, 25 Feb 2021 18:13:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eCQDyjSjrPOnC5kBdIWB+6uWOY9PLaOhvG7UuaHLMBs=; b=hzQEPy6po5uMlNt0Zt2fNrmKhe+2t6IXQjWLf9e9fSsIRAxq8g77yMUNBKK5YQVDqH Gi419EyzG4KPVI0SMS5MzP4bw48wj3nB9IWmuOSspMiQiS36aaxomlYQ6WVOSxTcCCmi nyMp5RNbCQDDnG7ygq/7HxOd0y8fssESR9iks= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eCQDyjSjrPOnC5kBdIWB+6uWOY9PLaOhvG7UuaHLMBs=; b=FuoVQKkSiQ1MDnACW4/F/I940g0LIk5TrOjrnsQjo7px3zufoncRSeA6PrYF0RwgSi MKekp5MsmrguUP71QJX4YExICGF2nO+0eoDmp66SK5sLJgQluoUWupaYi56ePvCyHiEo Q64lJAqO5LnliQ2oz3F2AqJOvxPg685p86hTPDNG+SufgXGY/UBSMlsuleRmWslBoj2X HWNdhC9F/ICp5ffsZcYOfQUe+hNzO9zMHN23QIhxhBBcanOQP/c3RvZEjFjDkBWZzf2d Bq/uMKNrpZ9ndDIefqcIvYEbliEjYqL/5LYo+Ga0M2GRuwKgyBLy/pUtTha1CfvNGkt1 EAiA== X-Gm-Message-State: AOAM531bc2NvQMEG6JUXhLf7L+5XmUARE3EICBIr62begbEvVTy/F9Un b2Dm5m4QVKqbmaLmTCnkZs81eA== X-Google-Smtp-Source: ABdhPJxbCC7G//bSUsPbyD6uOE13QyYXQG2FJO0dCZ69QsD+hhc3QGnvoJBGzIwOGDsY4l9xpjlXdw== X-Received: by 2002:a17:90a:7405:: with SMTP id a5mr936844pjg.13.1614305610829; Thu, 25 Feb 2021 18:13:30 -0800 (PST) Received: from localhost ([2620:15c:202:1:1d8:8d0c:f75e:edd8]) by smtp.gmail.com with UTF8SMTPSA id w24sm7119977pgl.19.2021.02.25.18.13.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Feb 2021 18:13:30 -0800 (PST) Date: Thu, 25 Feb 2021 18:13:28 -0800 From: Matthias Kaehlcke To: Douglas Anderson Cc: Bjorn Andersson , Stephen Boyd , Alexandru M Stan , Rob Clark , Philip Chen , Tzung-Bi Shih , Judy Hsiao , Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus Message-ID: References: <20210225221310.1939599-1-dianders@chromium.org> <20210225141022.12.If93a01b30d20dccacbad4be8ddc519dc20a51a1e@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210225141022.12.If93a01b30d20dccacbad4be8ddc519dc20a51a1e@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2021 at 02:13:09PM -0800, Douglas Anderson wrote: > This is a trogdor variant. This is mostly a grab from the downstream > tree with notable exceptions: > - I skip -rev0. This was a super early build and there's no advantage > of long term support. > - In -rev1 I translate the handling of the USB hub like is done for > similar boards. See the difference between the downstream and > upstream 'sc7180-trogdor-lazor-r0.dts' for an example. This will > need to be resolved when proper support for the USB hub is figured > out upstream. > - I remove sound node since sound hasn't landed upstream yet. > - In incorporate the pending for the > keyboard. > > Cc: Philip Chen > Cc: Matthias Kaehlcke > Cc: Stephen Boyd > Cc: Tzung-Bi Shih > Cc: Judy Hsiao > Signed-off-by: Douglas Anderson > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi > new file mode 100644 > index 000000000000..8f1596b8e90a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi > @@ -0,0 +1,288 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Pompom board device tree source > + * > + * Copyright 2020 Google LLC. > + */ > + > +#include "sc7180.dtsi" > + > +ap_ec_spi: &spi6 {}; > +ap_h1_spi: &spi0 {}; > + > +#include "sc7180-trogdor.dtsi" > + > +/ { > + thermal-zones { > + 5v-choke-thermal { > + polling-delay-passive = <0>; > + polling-delay = <250>; > + > + thermal-sensors = <&pm6150_adc_tm 0>; This is fine with how things are currently configured for trogdor, however be aware that in the ADC thermal monitor config your patch is racing with 'arm64: dts: qcom: sc7180: trogdor: Use ADC TM channel 0 instead of 1 for charger temperature' (https://lore.kernel.org/patchwork/patch/1384514/). That patch changes the charger thermistor for all trogdor boards to ADC TM channel 0, so the 5v-choke thermistor would have to move to another channel (most likely 1). > +&pm6150_adc_tm { > + status = "okay"; > + > + 5v-choke-thermistor@0 { > + reg = <0>; s/0/1/ in the two lines above if 'arm64: dts: qcom: sc7180: trogdor: Use ADC TM channel 0 instead of 1 for charger temperature' lands before this patch. The other deltas with downstream are mentioned in the commit message, as long as we keep the change of the ADC TM channel in mind this looks good to me. Reviewed-by: Matthias Kaehlcke