From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 299C0C433DB for ; Fri, 26 Feb 2021 10:21:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE29164EE2 for ; Fri, 26 Feb 2021 10:21:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbhBZKV0 (ORCPT ); Fri, 26 Feb 2021 05:21:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:43324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbhBZKVR (ORCPT ); Fri, 26 Feb 2021 05:21:17 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A61CC64EC4; Fri, 26 Feb 2021 10:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614334837; bh=iWoZ9kHmPVIJSFXhHK4exoa0+baGdJRJwmGpiqNK+/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vkSxfb1LL2dxJG2mqrUt7S7SoeFC66rpgkblbUXYtmiAlNUBUzaptcDXgjYjTzJbD 1f84Ihy8HQQiYdp6/p0BCWqB6nPl4AyPKKObowfYamz8qlslOVMIDEjbErFCryQ9FJ dCFsRMJoDc1RZ+Ixw5PAQA8GMl8oIxuYltKd7hck= Date: Fri, 26 Feb 2021 11:20:34 +0100 From: Greg KH To: Johan Hovold Cc: linux-usb@vger.kernel.org, Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: Re: [PATCH] USB: serial: xr: fix NULL-deref on disconnect Message-ID: References: <20210226100826.18987-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210226100826.18987-1-johan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 11:08:26AM +0100, Johan Hovold wrote: > Claiming the sibling control interface is a bit more involved and > specifically requires adding support to USB-serial core for managing > either interface being unbound first, something which could otherwise > lead to a NULL-pointer dereference. > > Similarly, additional infrastructure is also needed to handle suspend > properly. > > Since the driver currently isn't actually using the control interface, > we can defer this for now by simply not claiming the control interface. > > Fixes: c2d405aa86b4 ("USB: serial: add MaxLinear/Exar USB to Serial driver") > Reported-by: Mauro Carvalho Chehab > Cc: Manivannan Sadhasivam > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman