From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D24F7C433DB for ; Mon, 1 Mar 2021 09:19:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9946564D9E for ; Mon, 1 Mar 2021 09:19:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233839AbhCAJTJ (ORCPT ); Mon, 1 Mar 2021 04:19:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:42678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233751AbhCAJTF (ORCPT ); Mon, 1 Mar 2021 04:19:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 61AFF64E01; Mon, 1 Mar 2021 09:18:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614590304; bh=gVfBaC9t4lrXYWRSjC58vVIt9/hAhY6mrbALiLX78AI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ATP+2R9F4edZqLGKdjeEQQ1gGWuAM5vuZtw2Hx0SPgfcONLwBb+wtGGjqm56RNsTn sN6cg03B9gblos0R7mEJ7FtRUd8OTXWIuM9nyIlKQxYrJ6BSD+5I6SuR72XWPewoo+ Q6FkQk6aj81uuwwe8Ho9L6KMEMsWX2gXiZ/3L05Qh0HQ9hxAQiP3ZoqkkqF8IaIaIK vgVqkKjHa6AdL2AK72Wox+2PgepVvV1wEXEwmvYar9Pus6Cv+Zv6v7H0AKe53ND6SW x8BQ6nwzgClOk4k10xyLjlrcrBExrJl/HC/+EPcIcwXld/vY7qqZAocEjjI5U1/uZs AlJC1gLTjzdIQ== Received: from johan by xi.lan with local (Exim 4.93.0.4) (envelope-from ) id 1lGehN-0007sg-TM; Mon, 01 Mar 2021 10:18:41 +0100 Date: Mon, 1 Mar 2021 10:18:41 +0100 From: Johan Hovold To: Mauro Carvalho Chehab Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Greg Kroah-Hartman Subject: Re: [PATCH] USB: serial: xr: fix NULL-deref on disconnect Message-ID: References: <20210226100826.18987-1-johan@kernel.org> <20210226115447.6ace5490@coco.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210226115447.6ace5490@coco.lan> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 11:54:47AM +0100, Mauro Carvalho Chehab wrote: > Em Fri, 26 Feb 2021 11:08:26 +0100 > Johan Hovold escreveu: > > > Claiming the sibling control interface is a bit more involved and > > specifically requires adding support to USB-serial core for managing > > either interface being unbound first, something which could otherwise > > lead to a NULL-pointer dereference. > > > > Similarly, additional infrastructure is also needed to handle suspend > > properly. > > > > Since the driver currently isn't actually using the control interface, > > we can defer this for now by simply not claiming the control interface. > > > > Fixes: c2d405aa86b4 ("USB: serial: add MaxLinear/Exar USB to Serial driver") > > Reported-by: Mauro Carvalho Chehab > > Cc: Manivannan Sadhasivam > > Signed-off-by: Johan Hovold > > That solved the issue with XR21V1410: > > [ 8176.265862] usbcore: registered new interface driver xr_serial > [ 8176.265885] usbserial: USB Serial support registered for xr_serial > [ 8176.265921] xr_serial 2-1:1.1: xr_serial converter detected > [ 8176.266041] usb 2-1: xr_serial converter now attached to ttyUSB0 > [ 8176.268023] printk: console [ttyUSB0] enabled > [ 8186.512841] usb 2-1: USB disconnect, device number 5 > [ 8186.513131] printk: console [ttyUSB0] disabled > [ 8186.513340] xr_serial ttyUSB0: xr_serial converter now disconnected from ttyUSB0 > [ 8186.513376] xr_serial 2-1:1.1: device disconnected > > Tested-by: Mauro Carvalho Chehab Thanks for testing, and thanks to Greg and Manivannan for the review. Now applied. Johan