From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62B8C433E6 for ; Mon, 15 Mar 2021 22:25:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7812D64F56 for ; Mon, 15 Mar 2021 22:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232868AbhCOWZG (ORCPT ); Mon, 15 Mar 2021 18:25:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232307AbhCOWYz (ORCPT ); Mon, 15 Mar 2021 18:24:55 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 541EDC06175F for ; Mon, 15 Mar 2021 15:24:55 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id q5so8655933pgk.5 for ; Mon, 15 Mar 2021 15:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eSVlAX1fVhHy5kDtEAhAVCPc2Y7cisX9hzDXn3zscVI=; b=bjgBxGjHEMRNyeW5ZR60bTqODOEFFDPuFNQ2XqkxtP66eBtZvnGUH7QnK7SLaZe2kV 2MJE6/rNfD6fXtoE77q0KzViTXs3Bolxa4A0VLFpVa/hGpx9mzarl5SDjE5qcHLBvaBG /F5do3FaplK0gneUwJjvMDMETyEeXEs6Ht/UZpm9W6xigJvw3fSWDHXwuXChV/thnyMC m03EDozzPfncJ2gWNsDIQyO1HZz/ZjBscKzdWTPj9vyZUSdsIH/xwDeq9qukcZx+KTOE lWKdL2hf5KvgnJWtcVPbb7kyRtK239faccNX3NjYGn1+VLmzV4gijd6cP3l3vtt7ZDoe wZFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eSVlAX1fVhHy5kDtEAhAVCPc2Y7cisX9hzDXn3zscVI=; b=c5bfn7/AHL26wsQgEX39CA9UiM8nbrvRNuBrNSuHlwtobdukn9JqnYZyQMceO8F9U+ mun81SSirrJF01x/CQP0DOGY+NPiv9wYGRkg7lD+/qOOI7tDiljIXj/reiCs/kO8rhJ3 mbd1JISUk+ceVwnDafpt8DXSWT16hBSysdU5XgMszXpV8qX0JDBRJ0+xgWirDzBQS98Y WICrPgHQee/Hm3vxdkDUisCt58ipylVcT3f7USN+A/R+/UGngis4Z1RdLqcKcNCRjKV/ qdox35OUrL5iZtbOuYY3sUUwkIblfcY5ulY+pOTfqesVHZ+PwsWGchKG1Itva/uSFTyG WK4g== X-Gm-Message-State: AOAM5335bwg3f7dDfMeNjaW601Of72/ZK0cJbYXs6vSpHZD62H1LL+vR 9ijTxFelVz6KmP4jc/nKadVmxw== X-Google-Smtp-Source: ABdhPJxxxIwSByhv2EZChCu9P/0+HQoZiD8tGw1WkIfGR7VUosFxL+FfNkp6LAuFn1I8kagkCJeKHg== X-Received: by 2002:aa7:8e43:0:b029:1ed:447c:f1d4 with SMTP id d3-20020aa78e430000b02901ed447cf1d4mr11831394pfr.16.1615847094734; Mon, 15 Mar 2021 15:24:54 -0700 (PDT) Received: from google.com ([2620:15c:f:10:3d60:4c70:d756:da57]) by smtp.gmail.com with ESMTPSA id f15sm5790864pgr.90.2021.03.15.15.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 15:24:54 -0700 (PDT) Date: Mon, 15 Mar 2021 15:24:48 -0700 From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Peter Shier , Jim Mattson Subject: Re: [PATCH v2 3/4] KVM: x86/mmu: Factor out tdp_iter_return_to_root Message-ID: References: <20210315182643.2437374-1-bgardon@google.com> <20210315182643.2437374-4-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315182643.2437374-4-bgardon@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021, Ben Gardon wrote: > In tdp_mmu_iter_cond_resched there is a call to tdp_iter_start which > causes the iterator to continue its walk over the paging structure from > the root. This is needed after a yield as paging structure could have > been freed in the interim. > > The tdp_iter_start call is not very clear and something of a hack. It > requires exposing tdp_iter fields not used elsewhere in tdp_mmu.c and > the effect is not obvious from the function name. Factor a more aptly > named function out of tdp_iter_start and call it from > tdp_mmu_iter_cond_resched and tdp_iter_start. > > No functional change intended. > > Signed-off-by: Ben Gardon > --- Very nice, sooo much easier to read. Reviewed-by: Sean Christopherson