From: Greg KH <gregkh@linuxfoundation.org>
To: zhaoxiao <zhaoxiao@uniontech.com>
Cc: straube.linux@gmail.com, lu@pplo.net, dan.carpenter@oracle.com,
serrazimone@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: remove extra lines
Date: Mon, 15 Mar 2021 08:56:10 +0100 [thread overview]
Message-ID: <YE8TGufU6hyEBPgX@kroah.com> (raw)
In-Reply-To: <20210315072759.23107-1-zhaoxiao@uniontech.com>
On Mon, Mar 15, 2021 at 03:27:59PM +0800, zhaoxiao wrote:
> Remove extra lines in many functions in r8192U_wx.c.
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
You did mor than just remove extra lines :(
Also we need an extra line right before your signed-off-by line, as
checkpatch should have warned you about.
Please fix up and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-15 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 7:27 [PATCH] staging: rtl8192u: remove extra lines zhaoxiao
2021-03-15 7:56 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-16 9:59 zhaoxiao
2021-03-16 11:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YE8TGufU6hyEBPgX@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lu@pplo.net \
--cc=serrazimone@gmail.com \
--cc=straube.linux@gmail.com \
--cc=zhaoxiao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox