Re: [PATCH] char: lp: remove redundant space

Greg KH
2021-03-04T08:39:09Z

On Thu, Mar 04, 2021 at 04:17:52PM +0800, Qiang Ma wrote:
> These two lines of code don't meet the kernel coding style,
> so remove the redundant space.
>
> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
> ---
> drivers/char/lp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/lp.c b/drivers/char/lp.c
> index 862c2fd933c7..0e22e3b0a04e 100644
> --- a/drivers/char/lp.c
> +++ b/drivers/char/lp.c
> @@ -546,7 +546,7 @@ static int lp_open(struct inode *inode, struct file *file)
> }
> /* Determine if the peripheral supports ECP mode */
> lp_claim_parport_or_block(&lp_table[minor]);
> - if ( (lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
> + if ((lp_table[minor].dev->port->modes & PARPORT_MODE_ECP) &&
> !parport_negotiate(lp_table[minor].dev->port,
> IEEE1284_MODE_ECP)) {
> printk(KERN_INFO "lp%d: ECP mode\n", minor);
> @@ -590,7 +590,7 @@ static int lp_do_ioctl(unsigned int minor, unsigned int cmd,
> return -ENODEV;
> if ((LP_F(minor) & LP_EXIST) == 0)
> return -ENODEV;
> - switch ( cmd ) {
> + switch (cmd) {
> case LPTIME:
> if (arg > UINT_MAX / HZ)
> return -EINVAL;
> --
> 2.20.1
>
>
>

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot