From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E31C433E6 for ; Thu, 4 Mar 2021 12:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4BB064F35 for ; Thu, 4 Mar 2021 12:32:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240769AbhCDMcU (ORCPT ); Thu, 4 Mar 2021 07:32:20 -0500 Received: from mga12.intel.com ([192.55.52.136]:64847 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240760AbhCDMcJ (ORCPT ); Thu, 4 Mar 2021 07:32:09 -0500 IronPort-SDR: lOpvsh/+pV53UMz3o2yG/WNaMKW5x4AUeTpToiMvqqEhjClm0cNvInu+QzzqlKQJtoKRFvDs1U x4OA2YkoChpA== X-IronPort-AV: E=McAfee;i="6000,8403,9912"; a="166662527" X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="166662527" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 04:30:22 -0800 IronPort-SDR: OWSWa6ogXrvPlRkhxzoLRrtsDChwVgiPtl8arRcm6dBFZlYospEObzKBpa8eEUV9O+6UnB7gIu frS8+tu3N0Xg== X-IronPort-AV: E=Sophos;i="5.81,222,1610438400"; d="scan'208";a="400589553" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2021 04:30:21 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lHn7R-009sL0-Mn; Thu, 04 Mar 2021 14:30:17 +0200 Date: Thu, 4 Mar 2021 14:30:17 +0200 From: Andy Shevchenko To: Li Wang Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [V2][PATCH] vt: keyboard, fix uninitialized variables warning Message-ID: References: <2973260e-2405-5a70-f9bd-398d3d45346e@windriver.com> <1614827448-1594-1-git-send-email-li.wang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 04, 2021 at 02:28:55PM +0200, Andy Shevchenko wrote: > On Thu, Mar 04, 2021 at 11:10:48AM +0800, Li Wang wrote: > > drivers/tty/vt/keyboard.c: In function 'vt_do_kdgkb_ioctl': > > drivers/tty/vt/keyboard.c: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] > > return ret; > > ^~~ > > drivers/tty/vt/keyboard.c: warning: 'kbs' may be used uninitialized in this function [-Wmaybe-uninitialized] > > kfree(kbs); > > > Let me add one more comment and summarize altogether: > - Jiri wants you to have different error code > - Greg (and I noticed that as well) wants you to add a proper commit message, > and not just some output of some tool w/o context > - I want you to send a new version w/o chaining to the previous thread, so > start new (email) thread every time you send a new version > > Waiting for v3 in a separate email thread, thanks! Last, but not least: add a changelog after the cutter '---' line, so people will know what have you done on the transition from vX to vX+1. -- With Best Regards, Andy Shevchenko