From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E75C43381 for ; Fri, 5 Mar 2021 08:34:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD61D6502B for ; Fri, 5 Mar 2021 08:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbhCEIeZ (ORCPT ); Fri, 5 Mar 2021 03:34:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:49726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhCEIeC (ORCPT ); Fri, 5 Mar 2021 03:34:02 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5A8AE64DD1; Fri, 5 Mar 2021 08:34:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614933241; bh=vw6EGjbXZIEeWKBtB6myI1NVU4w2Gp7ON2w8kB2mftg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dXWlFuw6bYicLWfrlUcriO6QBzFSOivpu1TEl0bhDZ/u8QQq4sLt9dUcov/TNHnfN 9k8XY0HqFFjPV/uIuvoQTFsshxVGpGmm+o7DGTBi4q0IaSPSXeR8PEc3W06s0GgIDU lAQpvSC9ie7bbj8wZrcHrRmIsliG8JCIOBacpBIg= Date: Fri, 5 Mar 2021 09:33:32 +0100 From: Greg KH To: Geert Uytterhoeven Cc: Bartosz Golaszewski , Joel Becker , Christoph Hellwig , Shuah Khan , Linus Walleij , Andy Shevchenko , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Kent Gibson , Jonathan Corbet , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , "open list:DOCUMENTATION" , Bartosz Golaszewski Subject: Re: [PATCH v2 08/12] drivers: export device_is_bound() Message-ID: References: <20210304102452.21726-1-brgl@bgdev.pl> <20210304102452.21726-9-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 09:18:30AM +0100, Geert Uytterhoeven wrote: > CC Greg > > On Thu, Mar 4, 2021 at 11:30 AM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > Export the symbol for device_is_bound() so that we can use it in gpio-sim > > to check if the simulated GPIO chip is bound before fetching its driver > > data from configfs callbacks in order to retrieve the name of the GPIO > > chip device. > > > > Signed-off-by: Bartosz Golaszewski > > --- > > drivers/base/dd.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > > index 9179825ff646..c62c02e3490a 100644 > > --- a/drivers/base/dd.c > > +++ b/drivers/base/dd.c > > @@ -353,6 +353,7 @@ bool device_is_bound(struct device *dev) > > { > > return dev->p && klist_node_attached(&dev->p->knode_driver); > > } > > +EXPORT_SYMBOL_GPL(device_is_bound); No. Please no. Why is this needed? Feels like someone is doing something really wrong... NACK.