From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C264BC433E0 for ; Fri, 5 Mar 2021 20:29:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82E1464F60 for ; Fri, 5 Mar 2021 20:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229792AbhCEU2f (ORCPT ); Fri, 5 Mar 2021 15:28:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229465AbhCEU2X (ORCPT ); Fri, 5 Mar 2021 15:28:23 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44D0DC06175F for ; Fri, 5 Mar 2021 12:28:23 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id l7so2985641pfd.3 for ; Fri, 05 Mar 2021 12:28:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=piAdAlxX6cGUOE8F0JpLHJ9nmpFDMC1HCkTuqOWznxk=; b=ZMfRcZ4TDA8/dEClsxUS/L/u5rgoabu87qxGNj+0yZa6lwgQL/N63UEyBzxVDnJEjx DXNVeoKNIf5KrdFrRI9cQira81+9a6MNvsobpoLqJJddXEESNUp4iHimhrfUFs5l2/0G NY4CCDs4A9g/GCPH//PsA3BIjozH84M+Boneo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=piAdAlxX6cGUOE8F0JpLHJ9nmpFDMC1HCkTuqOWznxk=; b=daV1iGSM2CHh5snZFCyJBl9nbQSa4JygVfn7maFPN3V0NdgTx6cwL8xQuYbIwzKxkF GyYijaROUPQrjZwG4WLGYqmyDLyj+7Ij5LrS4DzYaOwSfEAzxZmPpLuscEWQSZoWBaSy pjrfb0NoU+U/BhclqkBTj2062CIJBpekey4sTWeXQfBIpQnHnoC7TCfwOX8bauH4DK3M Z/6wb8zajWDzexxHng1scZPWQjPq6d/I91b9tZ7C6BaqbFzUL02MT+QOifr777mFg4wZ m4a/nHIDGE3PsHVjLym3m9deSn2gj9uX6FD6lTGC+K6zAfnyTdYzJt6b1KwSF/LHYhB4 BZTw== X-Gm-Message-State: AOAM533JAbQ88BxfyZj5ouW55vfNHQjhL/Wc1Tcm4nG5DVxXldVk4fml BFXPJHfJdT5rMCLKOgJz2U38yXJoHshOLQ== X-Google-Smtp-Source: ABdhPJwDP89NM72Xmxkxt3+td/+HHTavGdq0RdR0KUyjCNPkQps+ga54WgNdcBG9JtaZDqAFts+g2Q== X-Received: by 2002:a63:fa4d:: with SMTP id g13mr10282679pgk.201.1614976102793; Fri, 05 Mar 2021 12:28:22 -0800 (PST) Received: from localhost ([2620:15c:202:1:2878:25d1:94cb:a547]) by smtp.gmail.com with UTF8SMTPSA id i128sm2955938pfe.64.2021.03.05.12.28.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 12:28:22 -0800 (PST) Date: Fri, 5 Mar 2021 12:28:20 -0800 From: Matthias Kaehlcke To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , LKML Subject: Re: [PATCH 4/4] arm64: dts: qcom: sc7180: Disable charger thermal zone for coachz rev1 and rev2 Message-ID: References: <20210304180415.1531430-1-mka@chromium.org> <20210304100341.4.I95b8a63103b77cab6a7cf9c150f0541db57fda98@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 10:50:12AM -0800, Doug Anderson wrote: > Hi, > > On Thu, Mar 4, 2021 at 10:04 AM Matthias Kaehlcke wrote: > > > > CoachZ rev1 and rev2 are stuffed with a 47k NTC as thermistor for the > > charger temperature which currently isn't supported by the PM6150 ADC > > driver. Disable the charger thermal zone to avoid the use of bogus > > temperature values. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts | 9 +++++++++ > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r2.dts | 9 +++++++++ > > 2 files changed, 18 insertions(+) > > I guess this patch is written with the assumption that eventually > we'll create a "-r3" or "-r4" that has a proper thermistor stuffed but > maybe we're not sure which one? Right now you're disabling it for > both -r1 and -r2+ which is all revisions, so this could go in the > coachz.dtsi file... The proper thermistor should be stuffed in rev3. For some reason there was already a -r3 .dts in my mental model, probably I created one when I started with a downstream version of this series just before you posted your's to bring upstream (mostly) in sync with downstream. I'll add it in v2.