Re: [PATCH 1/3] perf skel: Remove some unused variables.

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Sat, Mar 06, 2021 at 12:08:38AM -0800, Ian Rogers escreveu:
> Fixes -Wall warnings.

Thanks, tested all with:

  $ make BUILD_BPF_SKEL=1 PYTHON=python3 O=/tmp/build/perf -C tools/perf install-bin

Which makes me realize we need to turn both python3 and building the bpf
skel to be the default...

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c b/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> index c7cec92d0236..ab12b4c4ece2 100644
> --- a/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> +++ b/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> @@ -52,7 +52,7 @@ int BPF_PROG(fentry_XXX)
>  static inline void
>  fexit_update_maps(struct bpf_perf_event_value *after)
>  {
> -	struct bpf_perf_event_value *before, diff, *accum;
> +	struct bpf_perf_event_value *before, diff;
>  	__u32 zero = 0;
>  
>  	before = bpf_map_lookup_elem(&fentry_readings, &zero);
> @@ -78,7 +78,6 @@ int BPF_PROG(fexit_XXX)
>  {
>  	struct bpf_perf_event_value reading;
>  	__u32 cpu = bpf_get_smp_processor_id();
> -	__u32 one = 1, zero = 0;
>  	int err;
>  
>  	/* read all events before updating the maps, to reduce error */
> -- 
> 2.30.1.766.gb4fecdf3b7-goog
> 

-- 

- Arnaldo