From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B917C433E9 for ; Sun, 7 Mar 2021 09:14:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BF8865135 for ; Sun, 7 Mar 2021 09:14:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231395AbhCGJNf (ORCPT ); Sun, 7 Mar 2021 04:13:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:38912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231393AbhCGJN0 (ORCPT ); Sun, 7 Mar 2021 04:13:26 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5C45D65135; Sun, 7 Mar 2021 09:13:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615108406; bh=SEZex5rnGZhTc5ZP5HkX8RmLz9ASnYMBQobd3oDgRO8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=obhNE3LabZyZPW6jleR5IfMjeJ6Eblb2XtkZTZ/ReJFiZURpoWicIvKnH2Pa2otcZ 1aolAOG4mph1LoVZAnSK+3UamsfI+dcPynGiMzXzqZ5eoMvj1IyZ5uyizgXqX7myEQ JE6UscMBjJ9VQSNUwFTW/G/SDdbL42T92++7wu8b37k/hwOi8mL7NoWoXFaIZuJcfp uK+JQBOZzUhlsACJ4wUcjvpkYD51L/Tr0VBJaKb97QPIn3bsNlszzoDlZnyZ+at3+T 9FbDr6GI3p5qMWZROuDxvDtoSSmJuUTw7zXs04n4jgtZEQGsIOgmj8qsCLBxTqnZZb +Lc/J2w1uJdlw== Date: Sun, 7 Mar 2021 11:13:22 +0200 From: Leon Romanovsky To: Jia-Ju Bai Cc: bharat@chelsio.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] infiniband: hw: cxgb4: fix error return code of close_listsrv_rpl() Message-ID: References: <20210306135548.17939-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210306135548.17939-1-baijiaju1990@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 06, 2021 at 05:55:48AM -0800, Jia-Ju Bai wrote: > When ep is NULL, no error code of close_listsrv_rpl() is returned. > To fix this bug, close_listsrv_rpl() returns -EINVAL in this case. I don't think that this is an error. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai > --- > drivers/infiniband/hw/cxgb4/cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index 8769e7aa097f..94492d2dfdc7 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -2400,7 +2400,7 @@ static int close_listsrv_rpl(struct c4iw_dev *dev, struct sk_buff *skb) > > if (!ep) { > pr_warn("%s stid %d lookup failure!\n", __func__, stid); > - goto out; > + return -EINVAL; > } > pr_debug("ep %p\n", ep); > c4iw_wake_up_noref(ep->com.wr_waitp, status2errno(rpl->status)); > -- > 2.17.1 >