RE: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

David Laight
2021-03-09T09:13:31Z

...
> On Mon, Mar 08, 2021 at 07:23:34PM +0100, Marco Elver wrote:
> > On Mon, 8 Mar 2021 at 18:23, Petr Mladek <pmladek@suse.com> wrote:
>
> > > - pr_warn("**********************************************************\n");
> > > - pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
> > > - pr_warn("** **\n");
> > > - pr_warn("** This system shows unhashed kernel memory addresses **\n");
> > > - pr_warn("** via the console, logs, and other interfaces. This **\n");
> > > - pr_warn("** might reduce the security of your system. **\n");
> > > - pr_warn("** **\n");
> > > - pr_warn("** If you see this message and you are not debugging **\n");
> > > - pr_warn("** the kernel, report this immediately to your system **\n");
> >
> > While we're here: This paragraph can be shortened by saying what
> > kernel/trace/trace.c says ("..., report this immediately to your
> > vendor!") which avoids the "administrator! <lots of wasted spaces>".
>
> Aren't we discussed that and the point was that kernel configuration option is
> in administrator's realm?
>
> > > - pr_warn("** administrator! **\n");
> > > - pr_warn("** **\n");
> > > - pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
> > > - pr_warn("**********************************************************\n");

If you actually want anyone to notice it you need to splat it out
when root logs in - not just hidden in the middle of the boot messages.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)