From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B9CC433E0 for ; Mon, 8 Mar 2021 15:36:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECCFF65208 for ; Mon, 8 Mar 2021 15:36:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbhCHPgN (ORCPT ); Mon, 8 Mar 2021 10:36:13 -0500 Received: from mga11.intel.com ([192.55.52.93]:46195 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbhCHPgI (ORCPT ); Mon, 8 Mar 2021 10:36:08 -0500 IronPort-SDR: T/jzm5ekm7G7kb3w/vWln+K79bRWAuJ9dLiTl9RDAZm7JHywFwQjbAiU6A4neujWWMWBGG7xW9 l9Cme0P2TW+A== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="184687237" X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="184687237" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 07:36:04 -0800 IronPort-SDR: H+LKcMc4tq8UM/ho9ms7idR2V26uKk6ASKgTiCHCT7PAcnMYF6Rv7fcI62aO0obnCvQ+u0HbvE f4bkWLH/JMzQ== X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="508960716" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 07:36:01 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lJHvL-00Aqdb-DP; Mon, 08 Mar 2021 17:35:59 +0200 Date: Mon, 8 Mar 2021 17:35:59 +0200 From: Andy Shevchenko To: Maximilian Luz Cc: Mika Westerberg , Linus Walleij , Daniel Scally , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance" Message-ID: References: <20210308152505.3762055-1-luzmaximilian@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210308152505.3762055-1-luzmaximilian@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 08, 2021 at 04:25:05PM +0100, Maximilian Luz wrote: > Following commit 036e126c72eb ("pinctrl: intel: Split > intel_pinctrl_add_padgroups() for better maintenance"), > gpiochip_get_desc() is broken on some Kaby Lake R devices (specifically > a Microsoft Surface Book 2), returning -EINVAL for GPIOs that in reality > should be there (they are defined in ACPI and have been accessible > previously). Due to this, gpiod_get() fails with -ENOENT. > > Reverting this commit fixes that issue and the GPIOs in question are > accessible again. I would like to have more information. Can you enable PINCTRL and GPIO debug options in the kernel, and show dmesg output (when kernel command line has 'ignore_loglevel' option) for both working and non-working cases? Also if it's possible to have DSDT.dsl of the device in question along with output of `grep -H 15 /sys/bus/acpi/devices/*/status`. > There is probably a better option than straight up reverting this, so > consider this more of a bug-report. Indeed. -- With Best Regards, Andy Shevchenko