From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0556AC4332E for ; Mon, 8 Mar 2021 16:38:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAD936522E for ; Mon, 8 Mar 2021 16:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230481AbhCHQhj (ORCPT ); Mon, 8 Mar 2021 11:37:39 -0500 Received: from mga02.intel.com ([134.134.136.20]:15606 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbhCHQhc (ORCPT ); Mon, 8 Mar 2021 11:37:32 -0500 IronPort-SDR: WU12QE6EjUqKjz3pgat+RG0uwWTXLlJ7/710uz5dGIbZ+ZU+NxtWgMvPuawVgackwnrQkeU1ns 1PiaplggFqBA== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="175171804" X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="175171804" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:37:31 -0800 IronPort-SDR: 69g6RyvB8FvUhvlLwsDPayz5oaN+Bb4c3jgDX/TkKx67muWTCJ8ycFuCnuptY82bbL0yS9d4L2 zQ3hNqQthPRw== X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="519991117" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:37:27 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lJIsm-00ArFe-9N; Mon, 08 Mar 2021 18:37:24 +0200 Date: Mon, 8 Mar 2021 18:37:24 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Joel Becker , Christoph Hellwig , Shuah Khan , Linus Walleij , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Geert Uytterhoeven , Kent Gibson , Jonathan Corbet , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , linux-doc Subject: Re: [PATCH v2 09/12] gpio: sim: new testing module Message-ID: References: <20210304102452.21726-1-brgl@bgdev.pl> <20210304102452.21726-10-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 08, 2021 at 04:37:10PM +0100, Bartosz Golaszewski wrote: > On Mon, Mar 8, 2021 at 4:32 PM Andy Shevchenko > wrote: > > > > On Mon, Mar 08, 2021 at 04:13:33PM +0100, Bartosz Golaszewski wrote: > > > On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko > > > wrote: > > > > On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote: > > > > ... > > > > > > I have strong opinion not to open code "yet another parser". > > > > > > > > So, grepping on 'strsep(.*, ",")' shows a lot of code that wants something like > > > > this. Interesting are the net/9p cases. This in particular pointed out to > > > > lib/parser.c which in turn shows promising match_strlcpy() / match_strdup(). I > > > > haven't looked deeply though. > > > > > > > > That said, I agree that next_arg() is not the best here. > > > > > > Shall we revisit this once it's upstream with a generalization for > > > separating comma separated strings? > > > > How can we guarantee it won't be forgotten? > > > > I will add a REVISIT comment, so *obviously* it ***will*** be revisited. :) Fine by me! -- With Best Regards, Andy Shevchenko