public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marco Elver <elver@google.com>
Cc: Petr Mladek <pmladek@suse.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Vlastimil Babka <vbabka@suse.cz>, Timur Tabi <timur@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning
Date: Mon, 8 Mar 2021 20:36:23 +0200	[thread overview]
Message-ID: <YEZupyBiJD1zoLTi@smile.fi.intel.com> (raw)
In-Reply-To: <CANpmjNOS86kLPexXBZPwRB9=Ej6RHycJXCw_Z7cskMC+Jwb1Ag@mail.gmail.com>

On Mon, Mar 08, 2021 at 07:23:34PM +0100, Marco Elver wrote:
> On Mon, 8 Mar 2021 at 18:23, Petr Mladek <pmladek@suse.com> wrote:

> > -       pr_warn("**********************************************************\n");
> > -       pr_warn("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
> > -       pr_warn("**                                                      **\n");
> > -       pr_warn("** This system shows unhashed kernel memory addresses   **\n");
> > -       pr_warn("** via the console, logs, and other interfaces. This    **\n");
> > -       pr_warn("** might reduce the security of your system.            **\n");
> > -       pr_warn("**                                                      **\n");
> > -       pr_warn("** If you see this message and you are not debugging    **\n");
> > -       pr_warn("** the kernel, report this immediately to your system   **\n");
> 
> While we're here: This paragraph can be shortened by saying what
> kernel/trace/trace.c says ("..., report this immediately to your
> vendor!") which avoids the "administrator! <lots of wasted spaces>".

Aren't we discussed that and the point was that kernel configuration option is
in administrator's realm?

> > -       pr_warn("** administrator!                                       **\n");
> > -       pr_warn("**                                                      **\n");
> > -       pr_warn("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
> > -       pr_warn("**********************************************************\n");

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2021-03-08 18:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 19:42 [PATCH 1/2] lib/vsprintf: do not show no_hash_pointers message multiple times Marco Elver
2021-03-05 19:42 ` [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning Marco Elver
2021-03-06 20:27   ` Timur Tabi
2021-03-08 10:16   ` Petr Mladek
2021-03-08 10:51     ` Marco Elver
2021-03-12  3:46       ` Timur Tabi
2021-03-08 12:22     ` Geert Uytterhoeven
2021-03-08 17:23       ` Petr Mladek
2021-03-08 18:23         ` Marco Elver
2021-03-08 18:36           ` Andy Shevchenko [this message]
2021-03-09  9:12             ` David Laight
2021-03-08 10:33   ` Andy Shevchenko
2021-03-08 10:01 ` [PATCH 1/2] lib/vsprintf: do not show no_hash_pointers message multiple times Petr Mladek
2021-03-17 19:34   ` Marco Elver
2021-03-19 10:40     ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEZupyBiJD1zoLTi@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=elver@google.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=timur@kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox