From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B975EC433DB for ; Mon, 8 Mar 2021 18:37:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9378C6516B for ; Mon, 8 Mar 2021 18:37:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231221AbhCHShC (ORCPT ); Mon, 8 Mar 2021 13:37:02 -0500 Received: from mga17.intel.com ([192.55.52.151]:42699 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229972AbhCHSg3 (ORCPT ); Mon, 8 Mar 2021 13:36:29 -0500 IronPort-SDR: muAB8SEFJwCTHjIjpvErdt2jnWo3LE286OdarEzIBpPyUTJJ/jh60aInEfOQ/6B8ANMurWRlfO YzcNJKfJ2ffw== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="167996408" X-IronPort-AV: E=Sophos;i="5.81,233,1610438400"; d="scan'208";a="167996408" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 10:36:28 -0800 IronPort-SDR: 2aTtdn46OoZl2pQ9SbUHLlansm8jjvhnpQTN6xlmVYdUDcFsl6vcmgAniIQv7pax5i0/cGUIk4 S2afTbWyj63w== X-IronPort-AV: E=Sophos;i="5.81,233,1610438400"; d="scan'208";a="509015145" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 10:36:26 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lJKjv-00Asev-JV; Mon, 08 Mar 2021 20:36:23 +0200 Date: Mon, 8 Mar 2021 20:36:23 +0200 From: Andy Shevchenko To: Marco Elver Cc: Petr Mladek , Geert Uytterhoeven , Linux Kernel Mailing List , Vlastimil Babka , Timur Tabi , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes Subject: Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning Message-ID: References: <20210305194206.3165917-1-elver@google.com> <20210305194206.3165917-2-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 08, 2021 at 07:23:34PM +0100, Marco Elver wrote: > On Mon, 8 Mar 2021 at 18:23, Petr Mladek wrote: > > - pr_warn("**********************************************************\n"); > > - pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); > > - pr_warn("** **\n"); > > - pr_warn("** This system shows unhashed kernel memory addresses **\n"); > > - pr_warn("** via the console, logs, and other interfaces. This **\n"); > > - pr_warn("** might reduce the security of your system. **\n"); > > - pr_warn("** **\n"); > > - pr_warn("** If you see this message and you are not debugging **\n"); > > - pr_warn("** the kernel, report this immediately to your system **\n"); > > While we're here: This paragraph can be shortened by saying what > kernel/trace/trace.c says ("..., report this immediately to your > vendor!") which avoids the "administrator! ". Aren't we discussed that and the point was that kernel configuration option is in administrator's realm? > > - pr_warn("** administrator! **\n"); > > - pr_warn("** **\n"); > > - pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); > > - pr_warn("**********************************************************\n"); -- With Best Regards, Andy Shevchenko