From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04BC9C433E6 for ; Mon, 8 Mar 2021 23:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C488165290 for ; Mon, 8 Mar 2021 23:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230343AbhCHXgg (ORCPT ); Mon, 8 Mar 2021 18:36:36 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:39423 "EHLO mail-wr1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhCHXf5 (ORCPT ); Mon, 8 Mar 2021 18:35:57 -0500 Received: by mail-wr1-f43.google.com with SMTP id b18so13251261wrn.6; Mon, 08 Mar 2021 15:35:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K67rR2cz1Q7CfHsvPx+dMATB9DP+9YT/J61wglUubUU=; b=XSXLXD7bSgmNIwkJMdsQc5yVGbO6uxcvymq/gXvgUXZF/H6yjLGz89wDLKfDp1MCZv YSPwU14eGBsype4wsS5TQIfiSYaKnt/HLQnFeQFOG3xXv/GGZq8HdB12Q3dQLGju71qw P2oISYFClL7jmpVQIvqWJwTd4ItwnyT2VqVXBEnGJ2kNkvMt3HAx8S9h+p5X58gKGwvn POS+GGujkx/jPq1w/ABqMUiA/pIkXiL2nu5q2FLKcg+3J1eXMKU68eZHHRicj2qaw2nK zrS0PYSZlK1Ne9xIFRKOOBLXVPDIOa+QKw59MyFUnc9r05VS7HnWei1tF2MoaIX3Qyr/ QIKw== X-Gm-Message-State: AOAM531saXBqdHndJ4FKVXqzeOCKAE/y9BEjSdY4qHlSyGW3eQDyNGxK 598JxEnHtf7pqrjr73RwFUk= X-Google-Smtp-Source: ABdhPJxIo5ED286zGo5sDuM1NNSlbW7hAT37M57yIHfxV5NJ+vlrAPXSTvl4w23Q5VzJFHh51Jut6A== X-Received: by 2002:adf:fb05:: with SMTP id c5mr5345694wrr.302.1615246556238; Mon, 08 Mar 2021 15:35:56 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id u3sm20897860wrt.82.2021.03.08.15.35.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 15:35:55 -0800 (PST) Date: Tue, 9 Mar 2021 00:35:54 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Jim Quinlan Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Florian Fainelli , Philipp Zabel , Jim Quinlan , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v4 2/2] nPCI: brcmstb: Use reset/rearm instead of deassert/assert Message-ID: References: <20210308195037.1503-1-jim2101024@gmail.com> <20210308195037.1503-3-jim2101024@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210308195037.1503-3-jim2101024@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thank you for sending the patches over! > The Brcmstb PCIe RC uses a reset control "rescal" for certain chips. This [...] A small suggestion: it would be nicer to mention "Broadcom STB" rather than "Brcmstb" in the sentence above. [...] > +err1: > + reset_control_rearm(pcie->rescal); > +err0: > clk_disable_unprepare(pcie->clk); > return ret; [...] A small nitpick. Now that there are two labels on the error recovery path, it might be better to name both of these labels a little bit better. Some examples from the PCI tree: error_clock_unprepare err_disable_clock err_disable_clk err_clk_disable So it could be: err_reset: <-- or err_rearm or even err_reset_rearm, etc. reset_control_rearm(pcie->rescal); err_disable_clk: clk_disable_unprepare(pcie->clk); What do you think? Krzysztof