From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6294FC433E9 for ; Tue, 9 Mar 2021 14:55:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 224C765248 for ; Tue, 9 Mar 2021 14:55:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231806AbhCIOzU (ORCPT ); Tue, 9 Mar 2021 09:55:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:58242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231623AbhCIOyv (ORCPT ); Tue, 9 Mar 2021 09:54:51 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A476C65243; Tue, 9 Mar 2021 14:54:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615301691; bh=LX8COxWHcZN3mnZCsrWVPMO9Ej7yuJq5C2KwQ6bnL+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=laH7oULGQuFnAHGFGHABK0yPU9CPBFsZ4TdKkJqjldRGjv6goyAacRWfPQuxO3FjJ iJ45kRUfy+iI5NYF30aOC9hBApIfWGMybRTElvaSDBwE2DmDl/T/UvnrjmZyfLC81C 6hbZKMxx4BiFqHXAvc3kpobwekoqd4BFjQVO/V1E= Date: Tue, 9 Mar 2021 15:54:48 +0100 From: Greg KH To: =?iso-8859-1?B?Suly9G1l?= Pouiller Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Muhammad Usama Anjum Subject: Re: [PATCH] staging: wfx: remove unused included header files Message-ID: References: <20210211143637.GA177425@LEGION> <5120192.kWiexivLR2@pc-42> <2505525.pDR9D5mlbe@pc-42> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2505525.pDR9D5mlbe@pc-42> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 09, 2021 at 02:45:56PM +0100, Jérôme Pouiller wrote: > On Tuesday 9 March 2021 14:07:43 CET Greg KH wrote: > > On Thu, Mar 04, 2021 at 10:43:45AM +0100, Jérôme Pouiller wrote: > > > Hello Greg, > > > > > > On Tuesday 2 March 2021 16:01:25 CET Jérôme Pouiller wrote: > > > > Hello Muhammad, > > > > > > > > Sorry, I am a bit late for the review of this patch. Thank you for > your > > > > contribution. > > > > > > > > On Thursday 11 February 2021 15:36:37 CET Muhammad Usama Anjum > wrote: > > > > > > > > > > Many header files have been included, but never used. Those > header > > > > > files have been removed. > > > > > > > > > > Signed-off-by: Muhammad Usama Anjum > > > > > --- > > > > > drivers/staging/wfx/bh.c | 1 - > > > > > drivers/staging/wfx/bh.h | 4 ---- > > > > > drivers/staging/wfx/bus.h | 3 --- > > > > > drivers/staging/wfx/bus_sdio.c | 6 ------ > > > > > drivers/staging/wfx/bus_spi.c | 7 ------- > > > > > drivers/staging/wfx/data_rx.c | 5 ----- > > > > > drivers/staging/wfx/data_tx.c | 5 ----- > > > > > drivers/staging/wfx/data_tx.h | 3 --- > > > > > drivers/staging/wfx/debug.c | 6 ------ > > > > > drivers/staging/wfx/fwio.c | 2 -- > > > > > drivers/staging/wfx/hif_api_cmd.h | 4 ---- > > > > > drivers/staging/wfx/hif_api_general.h | 9 --------- > > > > > drivers/staging/wfx/hif_tx.c | 4 ---- > > > > > drivers/staging/wfx/hif_tx_mib.c | 5 ----- > > > > > drivers/staging/wfx/hwio.c | 3 --- > > > > > drivers/staging/wfx/hwio.h | 2 -- > > > > > drivers/staging/wfx/key.c | 2 -- > > > > > drivers/staging/wfx/key.h | 2 -- > > > > > drivers/staging/wfx/main.c | 7 ------- > > > > > drivers/staging/wfx/main.h | 3 --- > > > > > drivers/staging/wfx/queue.c | 4 ---- > > > > > drivers/staging/wfx/queue.h | 3 --- > > > > > drivers/staging/wfx/scan.h | 2 -- > > > > > drivers/staging/wfx/sta.c | 6 ------ > > > > > drivers/staging/wfx/sta.h | 2 -- > > > > > drivers/staging/wfx/traces.h | 3 --- > > > > > drivers/staging/wfx/wfx.h | 3 --- > > > > > 27 files changed, 106 deletions(-) > > > > > > > > > > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c > > > > > index ed53d0b45592..cd6bcfdfbe9a 100644 > > > > > --- a/drivers/staging/wfx/bh.c > > > > > +++ b/drivers/staging/wfx/bh.c > > > > > @@ -5,7 +5,6 @@ > > > > > * Copyright (c) 2017-2020, Silicon Laboratories, Inc. > > > > > * Copyright (c) 2010, ST-Ericsson > > > > > */ > > > > > -#include > > > > > #include > > > > > > > > Though bh.c refers to gpiod_set_value_cansleep() > > > > > > > > > > > > > #include "bh.h" > > > > > diff --git a/drivers/staging/wfx/bh.h b/drivers/staging/wfx/bh.h > > > > > index 78c49329e22a..92ef3298d4ac 100644 > > > > > --- a/drivers/staging/wfx/bh.h > > > > > +++ b/drivers/staging/wfx/bh.h > > > > > @@ -8,10 +8,6 @@ > > > > > #ifndef WFX_BH_H > > > > > #define WFX_BH_H > > > > > > > > > > -#include > > > > > -#include > > > > > -#include > > > > > - > > > > > struct wfx_dev; > > > > > > > > > > struct wfx_hif { > > > > > > > > Ditto, bh.h refers to atomic_t, struct work_struct and struct > > > > completion. If you try to compile bh.h alone (with something like > > > > gcc -xc .../bh.h) it won't work. > > > > > > > > Maybe it works now because we are lucky in the order the headers > are > > > > included, but I think it is not sufficient. > > > > > > > > [... same problem repeats multiple times in the following ...] > > > > > > > > > > Greg, if nobody has any opinion on that, I think that this patch > should > > > be reverted. > > > > Nothing is breaking, why should it be reverted? > > Because it is less maintainable? > > > You never build a .h file alone :) > > hmmm... notwithstanding, I thing that the code should not depend on the > order the headers are included. You don't? > > > Anyway, sure, I'll revert it, what is the commit id? > > commit 314fd52f01ea "staging: wfx: remove unused included header files" Now reverted, thanks. greg k-h