From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F57AC433DB for ; Tue, 9 Mar 2021 21:28:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AC9864F58 for ; Tue, 9 Mar 2021 21:28:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232032AbhCIV2T (ORCPT ); Tue, 9 Mar 2021 16:28:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:45500 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232005AbhCIV1y (ORCPT ); Tue, 9 Mar 2021 16:27:54 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3F49BAFF9; Tue, 9 Mar 2021 21:27:53 +0000 (UTC) Date: Tue, 9 Mar 2021 22:27:50 +0100 From: Oscar Salvador To: Dave Hansen Cc: Andrew Morton , David Hildenbrand , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/4] x86/vmemmap: Drop handling of 1GB vmemmap ranges Message-ID: References: <20210309174113.5597-1-osalvador@suse.de> <20210309174113.5597-3-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 09, 2021 at 10:34:51AM -0800, Dave Hansen wrote: > On 3/9/21 9:41 AM, Oscar Salvador wrote: > > We never get to allocate 1GB pages when mapping the vmemmap range. > > Drop the dead code both for the aligned and unaligned cases and leave > > only the direct map handling. > > I was hoping to seem some more meat in this changelog, possibly some of > what David Hildenbrand said in the v4 thread about this patch. > Basically, we don't have code to allocate 1G mappings because it isn't > clear that it would be worth the complexity, and it might also waste memory. > > I'm fine with the code, but I would appreciate a beefed-up changelog: > > Acked-by: Dave Hansen Since I had to do another pass to fix up some compilaton errors, I added a bit more of explanation in that regard. Thanks! -- Oscar Salvador SUSE L3