From: Greg KH <gregkh@linuxfoundation.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char/mwave: turn tp3780I_InitializeBoardData() into void function
Date: Wed, 10 Mar 2021 09:52:02 +0100 [thread overview]
Message-ID: <YEiIsmZ3O3Wk6DDq@kroah.com> (raw)
In-Reply-To: <1615365963-2096-1-git-send-email-yang.lee@linux.alibaba.com>
On Wed, Mar 10, 2021 at 04:46:03PM +0800, Yang Li wrote:
> This function always return '0' and no callers use the return value.
> So make it a void function.
>
> This eliminates the following coccicheck warning:
> ./drivers/char/mwave/tp3780i.c:182:5-11: Unneeded variable: "retval".
> Return "0" on line 187
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/char/mwave/tp3780i.c | 6 +-----
> drivers/char/mwave/tp3780i.h | 2 +-
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/mwave/tp3780i.c b/drivers/char/mwave/tp3780i.c
> index 5e1618a..8588b51 100644
> --- a/drivers/char/mwave/tp3780i.c
> +++ b/drivers/char/mwave/tp3780i.c
> @@ -177,14 +177,10 @@ int tp3780I_InitializeBoardData(THINKPAD_BD_DATA * pBDData)
> return retval;
> }
>
> -int tp3780I_Cleanup(THINKPAD_BD_DATA * pBDData)
> +void tp3780I_Cleanup(THINKPAD_BD_DATA *pBDData)
Your subject line does not match what the patch does :(
prev parent reply other threads:[~2021-03-10 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 8:46 [PATCH] char/mwave: turn tp3780I_InitializeBoardData() into void function Yang Li
2021-03-10 8:52 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEiIsmZ3O3Wk6DDq@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox