From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F214C433E0 for ; Wed, 10 Mar 2021 21:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E47EA64FC6 for ; Wed, 10 Mar 2021 21:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232667AbhCJV63 (ORCPT ); Wed, 10 Mar 2021 16:58:29 -0500 Received: from mx2.suse.de ([195.135.220.15]:57124 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232417AbhCJV6V (ORCPT ); Wed, 10 Mar 2021 16:58:21 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5306EAD87; Wed, 10 Mar 2021 21:58:20 +0000 (UTC) Date: Wed, 10 Mar 2021 22:58:17 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] x86/vmemmap: Handle unpopulated sub-pmd ranges Message-ID: References: <20210309174113.5597-1-osalvador@suse.de> <20210309174113.5597-4-osalvador@suse.de> <3471fe0e-d8f4-c8fe-2096-8d9c8b1ab5bc@redhat.com> <20210310174953.GA16289@linux> <1814c21c-b822-0ec6-c16d-92424d00663a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1814c21c-b822-0ec6-c16d-92424d00663a@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 06:58:26PM +0100, David Hildenbrand wrote: > Thinking again, I guess it might be a good idea to factor out the core > functions into common code. For the optimization part, it might make sense > too pass some "state" structure that contains e.g., "unused_pmd_start". Yeah, that really sounds like a good thing to do. > > Then we don't have diverging implementations of essentially the same thing. > > Of course, we can do that on top of this series - unifying both > implementations. I would rather do it on top of this series, not because I am lazy, but rather fairly busy and I will not be able to spend much time on it anytime soon. Once this series gets merged, I commit to have a look into that. Thanks! -- Oscar Salvador SUSE L3