From: Petr Mladek <pmladek@suse.com>
To: Chris Down <chris@chrisdown.name>
Cc: linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
John Ogness <john.ogness@linutronix.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
kernel-team@fb.com
Subject: Re: [PATCH v5] printk: Userspace format enumeration support
Date: Thu, 11 Mar 2021 10:20:09 +0100 [thread overview]
Message-ID: <YEngyd950bHqesez@alley> (raw)
In-Reply-To: <YEi47xUFix0Dg1Li@chrisdown.name>
On Wed 2021-03-10 12:17:51, Chris Down wrote:
> Hey Petr,
>
> Chris Down writes:
> > $ head -1 vmlinux; shuf -n 5 vmlinux
> > # <level[,flags]> filename:line function "format"
> > <5> block/blk-settings.c:661 disk_stack_limits "%s: Warning: Device %s is misaligned\n"
> > <4> kernel/trace/trace.c:8296 trace_create_file "Could not create tracefs '%s' entry\n"
> > <6> arch/x86/kernel/hpet.c:144 _hpet_print_config "hpet: %s(%d):\n"
> > <6> init/do_mounts.c:605 prepare_namespace "Waiting for root device %s...\n"
> > <6> drivers/acpi/osl.c:1410 acpi_no_auto_serialize_setup "ACPI: auto-serialization disabled\n"
>
> Regardless of any of the internals, how does this format look to you? I ask
> because the sooner we agree on the format, the sooner I can provide an
> interim version of this patch to internal customers, even if the eventual
> implementation changes a little :-)
It looks good to me.
I do not have any better idea. And I believe that the filename, line,
and function name might be useful.
Best Regards,
Petr
next prev parent reply other threads:[~2021-03-11 9:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 2:30 [PATCH v5] printk: Userspace format enumeration support Chris Down
2021-03-10 6:20 ` kernel test robot
2021-03-10 6:50 ` Greg Kroah-Hartman
2021-03-10 12:12 ` Chris Down
2021-03-10 12:16 ` Greg Kroah-Hartman
2021-03-11 9:34 ` Petr Mladek
2021-03-11 9:43 ` Greg Kroah-Hartman
2021-03-10 12:17 ` Chris Down
2021-03-11 9:20 ` Petr Mladek [this message]
2021-03-10 12:31 ` kernel test robot
2021-03-12 11:14 ` Petr Mladek
2021-03-12 13:53 ` Chris Down
2021-03-15 10:02 ` Petr Mladek
2021-03-15 12:20 ` Chris Down
2021-03-16 11:39 ` Petr Mladek
2021-03-16 13:27 ` Chris Down
2021-03-16 14:12 ` Rasmus Villemoes
2021-03-16 14:28 ` Chris Down
2021-03-17 8:40 ` Petr Mladek
2021-03-17 10:03 ` Rasmus Villemoes
2021-03-18 10:46 ` Petr Mladek
2021-03-18 11:31 ` Rasmus Villemoes
2021-03-19 11:43 ` Petr Mladek
2021-04-16 13:56 ` Chris Down
2021-04-16 14:09 ` Joe Perches
2021-04-16 14:29 ` Chris Down
2021-04-19 7:27 ` Rasmus Villemoes
2021-04-19 9:16 ` Petr Mladek
2021-04-19 9:53 ` Greg Kroah-Hartman
2021-04-19 11:02 ` Joe Perches
2021-04-21 13:14 ` Chris Down
2021-04-22 12:36 ` Joe Perches
2021-04-22 14:59 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEngyd950bHqesez@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox